Skip to content

Dagim H. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dagim02 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dagim H. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
675cf40
Implement date conversion module
Jan 28, 2026
c5da2d1
Implement date conversion module
Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion task-1/book.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
const bookTitle = "The fundamentals of JavaScript";

function isBookApplicable(searchString) {
// Your code here
const cleanSearch = searchString.trim().toLowerCase();
const cleanTitle = bookTitle.toLowerCase();

return cleanTitle.includes(cleanSearch);
Comment on lines +4 to +7
Copy link

@mo92othman mo92othman Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
You could also add a small check at the start of the function to handle empty or missing input before calling trim().

if (!searchString) {
  return false;
}

Copy link
Author

@Dagim02 Dagim02 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your feedback, it helps me improve my code.

}

console.log(isBookApplicable("javascript"));
console.log(isBookApplicable("javascript "));
console.log(isBookApplicable("python"));
console.log(isBookApplicable("JavaScript"));
console.log(isBookApplicable("JAVASCRIPT"));
30 changes: 29 additions & 1 deletion task-2/parse-date.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,29 @@
// Your code here
function parseDateString(dateString) {

const parts = dateString.split(" ");
const format = parts[0];
const dateValues = parts[1];
const values = dateValues.split("-");

let d, m, y;

if (format === "MDY") {
m = Number(values[0]);
d = Number(values[1]);
y = Number(values[2]);
} else {
Copy link

@mo92othman mo92othman Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, there is a small improvement coudl be done:
Here, the else will treats any format that is not "MDY" as "DMY".
This means invalid formats can still return a result, but with incorrect values.

For example:

parseDateString("AAA 03-15-2024");

Returns:

{ day: 3, month: 15, year: 2024 }

You could improve this by explicitly checking for "DMY" and handling invalid formats instead of using a generic else.

Copy link
Author

@Dagim02 Dagim02 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the insight. You’re right! adding an explicit check for "DMY" and handling invalid formats will make the parser more accurate. I’ll update my self accordingly.

d = Number(values[0]);
m = Number(values[1]);
y = Number(values[2]);
}

return {
day: d,
month: m,
year: y
};
}
console.log(parseDateString("MDY 10-21-1983"));
console.log(parseDateString("DMY 21-10-1983"));
console.log(parseDateString("MDY 03-15-2024"));
console.log(parseDateString("DMY 15-03-2024"));
19 changes: 19 additions & 0 deletions task-3/date.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Convert hours → minutes
export const convertHoursToMinutes = (hours) => {
return hours * 60;
};
export const convertMinutesToHours = (minutes) => {
return minutes / 60;
};
export const convertDaysToHours = (days) => {
return days * 24;
};
export const convertHoursToDays = (hours) => {
return hours / 24;
};
export const convertMinutesToSeconds = (minutes) => {
return minutes * 60;
};
export const convertSecondsToMinutes = (seconds) => {
return seconds / 60;
};
Comment on lines +2 to +19
Copy link

@mo92othman mo92othman Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of arrow functions 👍

120 changes: 41 additions & 79 deletions task-4/cleanup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,80 +1,42 @@
// Temperature conversion and weather report for City 1
let cityName1 = "Amsterdam";
let tempCelsius1 = 22;
let tempFahrenheit1 = (tempCelsius1 * 9 / 5) + 32;
let tempKelvin1 = tempCelsius1 + 273.15;
console.log("Weather Report for " + cityName1);
console.log("Temperature: " + tempCelsius1 + "°C");
console.log("Temperature: " + tempFahrenheit1 + "°F");
console.log("Temperature: " + tempKelvin1 + "K");
if (tempCelsius1 < 0) {
console.log("Status: Freezing");
} else if (tempCelsius1 >= 0 && tempCelsius1 < 10) {
console.log("Status: Cold");
} else if (tempCelsius1 >= 10 && tempCelsius1 < 20) {
console.log("Status: Mild");
} else if (tempCelsius1 >= 20 && tempCelsius1 < 30) {
console.log("Status: Warm");
} else {
console.log("Status: Hot");
}
console.log("---");
// Conversion Functions
const toFahrenheit = (celsius) => (celsius * 9/5) + 32;
const toKelvin = (celsius) => celsius + 273.15;
// Weather Status Function
const getWeatherStatus = (celsius) => {
if (celsius < 0) return "Freezing";
if (celsius < 10) return "Cold";
if (celsius < 20) return "Mild";
if (celsius < 30) return "Warm";
return "Hot";
};
// Wind Chill Function
const calculateWindChill = (tempCelsius, windSpeed) => {
return (
13.12 +
0.6215 * tempCelsius -
11.37 * Math.pow(windSpeed, 0.16) +
0.3965 * tempCelsius * Math.pow(windSpeed, 0.16)
);
};
// Main Weather Report Function
const printWeatherReport = (city, tempCelsius, windSpeed) => {
const fahrenheit = toFahrenheit(tempCelsius);
const kelvin = toKelvin(tempCelsius);
const status = getWeatherStatus(tempCelsius);
const windChill = calculateWindChill(tempCelsius, windSpeed);

// Temperature conversion and weather report for City 2
let cityName2 = "Berlin";
let tempCelsius2 = 15;
let tempFahrenheit2 = (tempCelsius2 * 9 / 5) + 32;
let tempKelvin2 = tempCelsius2 + 273.15;
console.log("Weather Report for " + cityName2);
console.log("Temperature: " + tempCelsius2 + "°C");
console.log("Temperature: " + tempFahrenheit2 + "°F");
console.log("Temperature: " + tempKelvin2 + "K");
if (tempCelsius2 < 0) {
console.log("Status: Freezing");
} else if (tempCelsius2 >= 0 && tempCelsius2 < 10) {
console.log("Status: Cold");
} else if (tempCelsius2 >= 10 && tempCelsius2 < 20) {
console.log("Status: Mild");
} else if (tempCelsius2 >= 20 && tempCelsius2 < 30) {
console.log("Status: Warm");
} else {
console.log("Status: Hot");
}
console.log("---");

// Temperature conversion and weather report for City 3
let cityName3 = "Copenhagen";
let tempCelsius3 = -5;
let tempFahrenheit3 = (tempCelsius3 * 9 / 5) + 32;
let tempKelvin3 = tempCelsius3 + 273.15;
console.log("Weather Report for " + cityName3);
console.log("Temperature: " + tempCelsius3 + "°C");
console.log("Temperature: " + tempFahrenheit3 + "°F");
console.log("Temperature: " + tempKelvin3 + "K");
if (tempCelsius3 < 0) {
console.log("Status: Freezing");
} else if (tempCelsius3 >= 0 && tempCelsius3 < 10) {
console.log("Status: Cold");
} else if (tempCelsius3 >= 10 && tempCelsius3 < 20) {
console.log("Status: Mild");
} else if (tempCelsius3 >= 20 && tempCelsius3 < 30) {
console.log("Status: Warm");
} else {
console.log("Status: Hot");
}
console.log("---");

// Wind chill calculation for City 1
let windSpeed1 = 15;
let windChill1 = 13.12 + 0.6215 * tempCelsius1 - 11.37 * Math.pow(windSpeed1, 0.16) + 0.3965 * tempCelsius1 * Math.pow(windSpeed1, 0.16);
console.log("Wind chill in " + cityName1 + ": " + windChill1.toFixed(2) + "°C");

// Wind chill calculation for City 2
let windSpeed2 = 20;
let windChill2 = 13.12 + 0.6215 * tempCelsius2 - 11.37 * Math.pow(windSpeed2, 0.16) + 0.3965 * tempCelsius2 * Math.pow(windSpeed2, 0.16);
console.log("Wind chill in " + cityName2 + ": " + windChill2.toFixed(2) + "°C");

// Wind chill calculation for City 3
let windSpeed3 = 25;
let windChill3 = 13.12 + 0.6215 * tempCelsius3 - 11.37 * Math.pow(windSpeed3, 0.16) + 0.3965 * tempCelsius3 * Math.pow(windSpeed3, 0.16);
console.log("Wind chill in " + cityName3 + ": " + windChill3.toFixed(2) + "°C");
console.log(`Weather Report for ${city}`);
console.log(`Temperature: ${tempCelsius}°C`);
console.log(`Temperature: ${fahrenheit}°F`);
console.log(`Temperature: ${kelvin}K`);
console.log(`Status: ${status}`);
console.log(`Wind chill in ${city}: ${windChill.toFixed(2)}°C`);
console.log("---");
};
// Original 3 Cities
printWeatherReport("Amsterdam", 22, 15);
printWeatherReport("Berlin", 15, 20);
printWeatherReport("Copenhagen", -5, 25);
// Bonus: Add 2 More Cities
printWeatherReport("Madrid", 30, 10);
printWeatherReport("Oslo", -12, 18);