-
Notifications
You must be signed in to change notification settings - Fork 18
Mustafa Homsi #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| function isBookApplicable(searchString) { | ||
| // Your code here | ||
| const isBookTitle = "The fundamentals of JavaScript"; | ||
|
|
||
| const cleanSearchString = searchString.trim().toLowerCase(); | ||
|
|
||
| const cleanTitle = isBookTitle.toLowerCase(); | ||
|
|
||
| return cleanTitle.includes(cleanSearchString); | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1 +1,25 @@ | ||||||
| // Your code here | ||||||
| function parseDateString(dateString) { | ||||||
| const trimmed = dateString.trim(); | ||||||
|
|
||||||
| const parts = trimmed.split(/\s+/); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This regular expression matches one or more whitespace characters (spaces, tabs). If this is how you understand it too, then this is an excellent choice. However, I would have accepted a space constant as a separator too here.
Suggested change
|
||||||
| const format = parts[0]; | ||||||
| const datePart = parts[1]; | ||||||
|
|
||||||
| const [first, second, yearStr] = datePart.split("-"); | ||||||
|
|
||||||
| const year = Number(yearStr); | ||||||
|
|
||||||
| if (format === "MDY") { | ||||||
| const month = Number(first); | ||||||
| const day = Number(second); | ||||||
| return { day, month, year,}; | ||||||
| } | ||||||
|
|
||||||
| const day = Number(first); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are assuming here that if it is not MDY, it must be DMY. That happens to be the case in the example console.logs. Maybe you could return an error message when it is not DMY so that it prints with the console.log? |
||||||
| const month = Number(second); | ||||||
| return { day, month, year,}; | ||||||
| } | ||||||
| console.log(parseDateString("MDY 10-21-1983")); | ||||||
| console.log(parseDateString("DMY 21-10-1983")); | ||||||
| console.log(parseDateString("MDY 03-15-2024")); | ||||||
| console.log(parseDateString("DMY 15-03-2024")); | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| export function convertHoursToMinutes(hours) { | ||
| return hours * 60; | ||
| } | ||
| export function convertMinutesToHours(minutes) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is a best practice to separate function definitions with a blank line, for readability purposes. |
||
| return minutes / 60; | ||
| } | ||
| export function convertDaysToHours(days) { | ||
| return days * 24; | ||
| } | ||
| export function convertHoursToDays(hours) { | ||
| return hours / 24; | ||
| } | ||
| export function convertMinutesToSeconds(minutes) { | ||
| return minutes * 60; | ||
| } | ||
| export function convertSecondsToMinutes(seconds) { | ||
| return seconds / 60; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,80 +1,49 @@ | ||
| // Temperature conversion and weather report for City 1 | ||
| let cityName1 = "Amsterdam"; | ||
| let tempCelsius1 = 22; | ||
| let tempFahrenheit1 = (tempCelsius1 * 9 / 5) + 32; | ||
| let tempKelvin1 = tempCelsius1 + 273.15; | ||
| console.log("Weather Report for " + cityName1); | ||
| console.log("Temperature: " + tempCelsius1 + "°C"); | ||
| console.log("Temperature: " + tempFahrenheit1 + "°F"); | ||
| console.log("Temperature: " + tempKelvin1 + "K"); | ||
| if (tempCelsius1 < 0) { | ||
| console.log("Status: Freezing"); | ||
| } else if (tempCelsius1 >= 0 && tempCelsius1 < 10) { | ||
| console.log("Status: Cold"); | ||
| } else if (tempCelsius1 >= 10 && tempCelsius1 < 20) { | ||
| console.log("Status: Mild"); | ||
| } else if (tempCelsius1 >= 20 && tempCelsius1 < 30) { | ||
| console.log("Status: Warm"); | ||
| } else { | ||
| console.log("Status: Hot"); | ||
|
|
||
| function tempCelsiusToFahrenheit(tempCelsius) { | ||
| return (tempCelsius * 9 / 5) + 32; | ||
| } | ||
| function tempCelsiusToKelvin(tempCelsius) { | ||
| return tempCelsius + 273.15; | ||
| } | ||
| console.log("---"); | ||
| function getTemperatureStatus(tempCelsius) { | ||
| if (tempCelsius < 0) return "Freezing"; | ||
| else if (tempCelsius >= 0 && tempCelsius < 10) return "Cold"; | ||
| else if (tempCelsius >= 10 && tempCelsius < 20) return "Mild"; | ||
| else if (tempCelsius >= 20 && tempCelsius < 30) return "Warm"; | ||
| return "Hot"; | ||
| } | ||
|
|
||
| function printWeatherReport(city, tempCelsius) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are the function definitions from |
||
| let tempFahrenheit = tempCelsiusToFahrenheit(tempCelsius); | ||
| let tempKelvin = tempCelsiusToKelvin(tempCelsius); | ||
| let status = getTemperatureStatus(tempCelsius); | ||
|
|
||
| // Temperature conversion and weather report for City 2 | ||
| let cityName2 = "Berlin"; | ||
| let tempCelsius2 = 15; | ||
| let tempFahrenheit2 = (tempCelsius2 * 9 / 5) + 32; | ||
| let tempKelvin2 = tempCelsius2 + 273.15; | ||
| console.log("Weather Report for " + cityName2); | ||
| console.log("Temperature: " + tempCelsius2 + "°C"); | ||
| console.log("Temperature: " + tempFahrenheit2 + "°F"); | ||
| console.log("Temperature: " + tempKelvin2 + "K"); | ||
| if (tempCelsius2 < 0) { | ||
| console.log("Status: Freezing"); | ||
| } else if (tempCelsius2 >= 0 && tempCelsius2 < 10) { | ||
| console.log("Status: Cold"); | ||
| } else if (tempCelsius2 >= 10 && tempCelsius2 < 20) { | ||
| console.log("Status: Mild"); | ||
| } else if (tempCelsius2 >= 20 && tempCelsius2 < 30) { | ||
| console.log("Status: Warm"); | ||
| } else { | ||
| console.log("Status: Hot"); | ||
| console.log("Weather Report for " + city); | ||
| console.log("Temperature: " + tempCelsius + "°C"); | ||
| console.log("Temperature: " + tempFahrenheit + "°F"); | ||
| console.log("Temperature: " + tempKelvin + "K"); | ||
| console.log("Status: " + status); | ||
| console.log("---"); | ||
| } | ||
| function calculateWindChill(tempCelsius, windSpeed) { | ||
| return ( | ||
| 13.12 + | ||
| 0.6215 * tempCelsius - | ||
| 11.37 * Math.pow(windSpeed, 0.16) + | ||
| 0.3965 * tempCelsius * Math.pow(windSpeed, 0.16) | ||
| ); | ||
| } | ||
| console.log("---"); | ||
|
|
||
| // Temperature conversion and weather report for City 3 | ||
| let cityName3 = "Copenhagen"; | ||
| let tempCelsius3 = -5; | ||
| let tempFahrenheit3 = (tempCelsius3 * 9 / 5) + 32; | ||
| let tempKelvin3 = tempCelsius3 + 273.15; | ||
| console.log("Weather Report for " + cityName3); | ||
| console.log("Temperature: " + tempCelsius3 + "°C"); | ||
| console.log("Temperature: " + tempFahrenheit3 + "°F"); | ||
| console.log("Temperature: " + tempKelvin3 + "K"); | ||
| if (tempCelsius3 < 0) { | ||
| console.log("Status: Freezing"); | ||
| } else if (tempCelsius3 >= 0 && tempCelsius3 < 10) { | ||
| console.log("Status: Cold"); | ||
| } else if (tempCelsius3 >= 10 && tempCelsius3 < 20) { | ||
| console.log("Status: Mild"); | ||
| } else if (tempCelsius3 >= 20 && tempCelsius3 < 30) { | ||
| console.log("Status: Warm"); | ||
| } else { | ||
| console.log("Status: Hot"); | ||
| function printWindChill(city, tempCelsius, windSpeed) { | ||
| const windChill = calculateWindChill(tempCelsius, windSpeed); | ||
| console.log("Wind chill in " + city + ": " + windChill.toFixed(2) + "°C"); | ||
| } | ||
| console.log("---"); | ||
| printWeatherReport("Amsterdam", 22); | ||
|
|
||
| // Wind chill calculation for City 1 | ||
| let windSpeed1 = 15; | ||
| let windChill1 = 13.12 + 0.6215 * tempCelsius1 - 11.37 * Math.pow(windSpeed1, 0.16) + 0.3965 * tempCelsius1 * Math.pow(windSpeed1, 0.16); | ||
| console.log("Wind chill in " + cityName1 + ": " + windChill1.toFixed(2) + "°C"); | ||
| printWeatherReport("berlin", 15); | ||
|
|
||
| // Wind chill calculation for City 2 | ||
| let windSpeed2 = 20; | ||
| let windChill2 = 13.12 + 0.6215 * tempCelsius2 - 11.37 * Math.pow(windSpeed2, 0.16) + 0.3965 * tempCelsius2 * Math.pow(windSpeed2, 0.16); | ||
| console.log("Wind chill in " + cityName2 + ": " + windChill2.toFixed(2) + "°C"); | ||
| printWeatherReport("Copenhagen", 5); | ||
|
|
||
| // Wind chill calculation for City 3 | ||
| let windSpeed3 = 25; | ||
| let windChill3 = 13.12 + 0.6215 * tempCelsius3 - 11.37 * Math.pow(windSpeed3, 0.16) + 0.3965 * tempCelsius3 * Math.pow(windSpeed3, 0.16); | ||
| console.log("Wind chill in " + cityName3 + ": " + windChill3.toFixed(2) + "°C"); | ||
| printWindChill("Amsterdam", 22, 15); | ||
| printWindChill("Berlin", 15, 20); | ||
| printWindChill("Copenhagen", 5, 25); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, but it would be easier to check if you included the code to run the tests.