Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
remarcmij
requested changes
Feb 1, 2026
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi @mohammedalfakih-dev, thanks for your PR. Task-4 needs your attention.
| return normalizedTitle.includes(normalizedSearch); | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
Make your code nice to read,
not only for the computer, but for humans too: pay
attention to proper indentation.
| year: Number(third) | ||
| }; | ||
| } else { | ||
| // DMY format: Day-Month-Year |
There was a problem hiding this comment.
That's what you hope for, but you leave it untested.
|
|
||
| export function convertSecondsToMinutes(seconds) { | ||
| return seconds / 60; | ||
| } No newline at end of file |
| generateWeatherReport("Amsterdam", 5, 20); | ||
| generateWeatherReport("London", 8, 15); | ||
| generateWeatherReport("New York", -2, 25); | ||
| generateWeatherReport("Tokyo", 12, 10); No newline at end of file |
There was a problem hiding this comment.
You did not meet this requirement from the assignment:
The refactored code should produce the same output as the original
Your code:
Weather Report for Amsterdam:
Temperature: 5C (41.0F)
Wind Speed: 20 km/h
Wind Chill: 1.1C
Weather Report for London:
Temperature: 8C (46.4F)
Wind Speed: 15 km/h
Wind Chill: 5.4C
Weather Report for New York:
Temperature: -2C (28.4F)
Wind Speed: 25 km/h
Wind Chill: -8.5C
Weather Report for Tokyo:
Temperature: 12C (53.6F)
Wind Speed: 10 km/h
Wind Chill: 11.0C
Original code:
Weather Report for Amsterdam
Temperature: 22°C
Temperature: 71.6°F
Temperature: 295.15K
Status: Warm
---
Weather Report for Berlin
Temperature: 15°C
Temperature: 59°F
Temperature: 288.15K
Status: Mild
---
Weather Report for Copenhagen
Temperature: -5°C
Temperature: 23°F
Temperature: 268.15K
Status: Freezing
---
Wind chill in Amsterdam: 22.71°C
Wind chill in Berlin: 13.69°C
Wind chill in Copenhagen: -12.34°C
remarcmij
added
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.