Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
mo92othman
approved these changes
Feb 5, 2026
mo92othman
left a comment
mo92othman
left a comment
There was a problem hiding this comment.
Hi @shmoonwalker , well done! 👍
Good job refactoring the code in Task 4. You show a good understanding of the DRY principle. Good luck in the next modules!
Comment on lines
+19
to
+36
| if (dateFormat === "MDY") { | ||
| return { | ||
| month: partOne, | ||
| day: partTwo, | ||
| year: yearValue | ||
| }; | ||
| } | ||
|
|
||
| if (dateFormat === "DMY") { | ||
| return { | ||
| day: partOne, | ||
| month: partTwo, | ||
| year: yearValue | ||
| }; | ||
| } | ||
|
|
||
| return "Invalid date input"; | ||
| }; |
Comment on lines
+1
to
+6
| export const convertHoursToMinutes = (hour) => hour * 60; | ||
| export const convertMinutesToHours = (minute) => minute / 60; | ||
| export const convertDaysToHours = (days) => days * 24; | ||
| export const convertHoursToDays = (hour) => hour / 24 ; | ||
| export const convertMinutesToSeconds = (minute) => minute * 60; | ||
| export const convertSecondsToMinutes = (second) => second / 60; No newline at end of file |
mo92othman
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete task for week 3