Conversation
This comment has been minimized.
This comment has been minimized.
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi @halyna1995, thanks for your submission. I have some comments below, but will approve your PR now.
task-1/book.js
Outdated
|
|
||
| function normalizeText(s) { | ||
| return String(s).trim().toLowerCase().replace(/\s+/g, " "); | ||
| } |
There was a problem hiding this comment.
Make your code nice to read,
not only for the computer, but for humans too: pay
attention to proper indentation.
| } else if (format === "DMY") { | ||
| [day, month, year] = numbers; // Day-Month-Year | ||
| } else { | ||
| throw new Error("Unknown date format. Expected 'MDY' or 'DMY'."); |
There was a problem hiding this comment.
When you deliberately throw an error you should also handle the error somewhere else in your code. Otherwise the error is passed on to the host environment, in this case Node.js, which terminates your program with a stack trace, like this:
Error: Unknown date format. Expected 'MDY' or 'DMY'.
at parseDateString (/Volumes/Crucial2TB/xdev/hackyourfuture/c55-core-week-3/task-2/parse-date.js:12:11)
at Object.<anonymous> (/Volumes/Crucial2TB/xdev/hackyourfuture/c55-core-week-3/task-2/parse-date.js:17:13)
at Module._compile (node:internal/modules/cjs/loader:1761:14)
at Object..js (node:internal/modules/cjs/loader:1893:10)
at Module.load (node:internal/modules/cjs/loader:1481:32)
at Module._load (node:internal/modules/cjs/loader:1300:12)
at TracingChannel.traceSync (node:diagnostics_channel:328:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:245:24)
at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
at node:internal/main/run_main_module:33:47
Error handling is covered in week 6, so don't worry about it now.
|
|
||
| export function convertSecondsToMinutes(seconds){ | ||
| return seconds / 60; | ||
| } No newline at end of file |
| console.log("Wind chill in " + cityName3 + ": " + windChill3.toFixed(2) + "°C"); No newline at end of file | ||
| for (const c of cities) { | ||
| printWindChill(c.name, c.tempC, c.wind); | ||
| } |
There was a problem hiding this comment.
This looks like a perfect cleanup of the original code. If this is completely your own work, well done. However, if some or all of it is done through genAI then please take note of the Code of Conduct that Peter posted in slack.
There was a problem hiding this comment.
Thanks! Just to clarify: I used a bit of AI only to translate parts of the assignment and for learning/explanations, not to generate the code. I wrote the solution myself, and I understand what each function and line is doing.
remarcmij
added
the
Reviewed
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
2 participants
All tasks are complete