Skip to content

Salem Ba-rabuod #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Barboud wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Salem Ba-rabuod #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions task-1/leap-year.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@ import promptSync from 'prompt-sync';
const prompt = promptSync();


// Write your code here
// Guidance:
// Step 1: prompt the user to enter a year
// Step 2: convert the user input to a number so we can perform calculations
// Step 3: Implement the logic
console.log('Leap Year Check program!');

const year = parseInt(prompt('Enter a year: '));

if ( isNaN(year) || (year > 9999) || (year < 1)) {
console.log('Invalid year!');
} else {
Copy link

@rafaelhdr rafaelhdr Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great. I have one suggestion, that was not really necessary, but might make the code more clean.

Here is the explanation of early return: https://medium.com/swlh/return-early-pattern-3d18a41bba8

This is small code, so that is fine. But when the code starts growing, you can return things early, and the code is easier to read.

Copy link
Author

@Barboud Barboud Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new information to me; I'll try to use this from now on. Thanks:)


if ( (Number.isInteger(year/400) === true) || ( (Number.isInteger(year/4) === true) && (Number.isInteger(year/100) === false) ) ) {
console.log('Yes, ' + year + ' is a leap year');
} else {
console.log('No, ' + year + ' is not a leap year');
}

}
19 changes: 16 additions & 3 deletions task-2/login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,22 @@ import { errorMessage, successMessage } from './app.js';
let incorrectAttempts = 0;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
// Use incorrectAttempts to track the number of failed attempts


if (incorrectAttempts < 3) {

if ( (username === 'admin' && password === 'Hack1234') || (username === 'user' && password === '7654321') ) {
successMessage('Logged in successfully');
} else {
errorMessage('Incorrect credentials');
incorrectAttempts++;
}

} else {
errorMessage('Login blocked: Too many incorrect attempts');
}


}

// Do not change the line below
Expand Down
15 changes: 9 additions & 6 deletions task-3/converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: ");
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
console.log("3: Display the current exchange rate");
const menuSelection = prompt("Select your option [1, 2, or 3]: ");

console.log("\n");

if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -29,9 +30,11 @@ if (menuSelection === "1") {
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');
const eurAmount = usdAmountNum / EUR_USD_RATE;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.');
}
} else if (menuSelection === "3") {
console.log("The current exchange rate is 1 EUR = "+ EUR_USD_RATE + " USD.");
} else {
console.log("Invalid selection. Please choose either 1 or 2.");
console.log("Invalid selection. Please choose either 1, 2, or 3.");
}
Loading