Skip to content

Mohamad Bader AA #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noneeeed wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Mohamad Bader AA #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c17cb7
initial commit task 1
noneeeed Jan 20, 2026
d16cff0
initial commit, added success and error msgs
noneeeed Jan 20, 2026
3229f45
task 3 initial commit fixed 3 bugs and added a function (option 3 = e…
noneeeed Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions task-1/leap-year.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,24 @@
import promptSync from 'prompt-sync';
const prompt = promptSync();
let year = prompt('Enter a year: ');
year = Number(year);

if (isNaN(year)) {
console.log('Invalid input. Please enter a number');
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output needs to be Invalid year!. In programming, requirements are very important to the point. So, as per the assignment, these are the only valid outputs:

- "Yes, <YEAR> is a leap year"
- "No, <YEAR> is not a leap year"
- “Invalid year!”

process.exit();
}
if (year <= 0 || year > 9999) {
console.log('Invalid year!');
process.exit();
}

// Write your code here
// Guidance:
// Step 1: prompt the user to enter a year
// Step 2: convert the user input to a number so we can perform calculations
// Step 3: Implement the logic
if (year / 100 === Math.floor(year / 100) && year / 400 === Math.floor(year / 400)) {
console.log('Yes ' + year + ' is a leap year');
} else if (year / 100 === Math.floor(year / 100)) {
console.log('No ' + year + ' is not a leap year');
} else if (year / 4 === Math.floor(year / 4)) {
console.log('Yes ' + year + ' is a leap year');
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you met all the required conditions. However, one improvement would be to follow the DRY principle. In programming, there is a principle called DRY (Don't Repeat Yourself). So, in this case, for example, you could create a variable called isLeapYear and reuse it wherever needed. Also, this way you could avoid repeating the same console statement, and the code becomes more readable for the future. Like, for example:

const isLeapYear = (year % 4 === 0) && (year % 100 !== 0 || year % 400 === 0);

if (isLeapYear) {
  console.log(`Yes, ${year} is a leap year`);
} else {
  console.log(`No, ${year} is not a leap year`);
}

}
else {
console.log('No ' + year + ' is not a leap year');
}
23 changes: 17 additions & 6 deletions task-2/login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,24 @@
// Do not change the line below
import { errorMessage, successMessage } from './app.js';

let incorrectAttempts = 0;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
// Use incorrectAttempts to track the number of failed attempts
if (incorrectAttempts > 3) {
errorMessage('Login blocked: too many incorrect attempts');
return;
}
if ((username === 'admin' && password === 'Hack1234') || (username === 'user' && password === '7654321')) {
successMessage('Logged in successfully');
incorrectAttempts = 0;
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details matter. There is no requirement to reset incorrectAttempts if the login was successful.


}
else {
errorMessage('Incorrect credentials');
incorrectAttempts ++;
if (incorrectAttempts > 3) {
errorMessage('Login blocked: too many incorrect attempts');
return;
}
}
}

// Do not change the line below
export { onLogin };
18 changes: 12 additions & 6 deletions task-3/converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: ");
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
console.log("3: Display current exchange rate");
const menuSelection = prompt("Select your option [1 ,2 or 3]: ");

console.log("\n");

if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the error message, the logic should check if the inputted eur amount is a valid positive number:

eurAmountNum <= 0

console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -29,9 +30,14 @@ if (menuSelection === "1") {
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the error message, the logic should check if the inputted amount is a valid positive number:

usdAmountNum <= 0

console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');
const eurAmount = usdAmountNum / EUR_USD_RATE;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.');
}
} else if (menuSelection === "3") {
// Display exchange rate
console.log("Current exchange rate:");
console.log("1 EUR = " + EUR_USD_RATE.toFixed(4) + " USD");
console.log("1 USD = " + (1 / EUR_USD_RATE).toFixed(4) + " EUR");
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For option 3, the output should be The current exchange rate is 1 EUR = 1.1643 USD.

} else {
console.log("Invalid selection. Please choose either 1 or 2.");
console.log("Invalid selection. Please choose either 1 or 2 or 3.");
}
Loading