Skip to content

Atiqa N. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atiqanaseer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Atiqa N. #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e91aa32
Atiqa week 2 assignment task 1
atiqanaseer Jan 21, 2026
6f6a3c3
Atiqa week 2 assignment task 2
atiqanaseer Jan 21, 2026
0471dfd
Atiqa week 2 assignment task 3
atiqanaseer Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions task-1/leap-year.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
import promptSync from 'prompt-sync';
const prompt = promptSync();

const year = prompt("Enter a year: "); // prompt user to enter a year
const yearNumber = Number(year); // convert the user input to number
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly named variables, very nice!


// Write your code here
// Guidance:
// Step 1: prompt the user to enter a year
// Step 2: convert the user input to a number so we can perform calculations
// Step 3: Implement the logic
// First check if the number is valid and year is from 1 to 9999
if (!isNaN(yearNumber) && yearNumber >= 1 && yearNumber <= 9999) {
// Then check if the year is leap year or not
if (yearNumber % 4 === 0 && (yearNumber % 400 === 0 || yearNumber % 100 !== 0)) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you met all the required conditions. However, one improvement would be to follow the DRY principle. In programming, there is a principle called DRY (Don't Repeat Yourself). So, for example, you could create a variable called isLeapYear and reuse it. Also, this way, the code becomes more readable for the future. Like, for example:

const isLeapYear = (year % 4 === 0) && (year % 100 !== 0 || year % 400 === 0);

if (isLeapYear) {
  console.log(`Yes, ${year} is a leap year`);
} else {
  console.log(`No, ${year} is not a leap year`);
}

console.log(`Yes, ${yearNumber} is a leap year`);
} else {
console.log(`No, ${yearNumber} is not a leap year`);
}
} else {
console.log("Invalid year!");
}
16 changes: 13 additions & 3 deletions task-2/login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@ import { errorMessage, successMessage } from './app.js';
let incorrectAttempts = 0;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
// Use incorrectAttempts to track the number of failed attempts
// Check if more than 3 incorrect attempts then show login block error message
if (incorrectAttempts > 3) {
errorMessage('Login blocked: Too many incorrect attempts');
return; // Don't run the code further in this function
}

// Check if any of the two username and password combination are correct then show success else show error
if ((username === 'admin' && password === 'Hack1234') || (username === 'user' && password === '7654321')) {
successMessage('Logged in successfully');
} else {
errorMessage('Incorrect credentials');
incorrectAttempts++; // Increase incorrect login attempt by 1
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, you need to check if incorrectAttempts has reached 4. If it is 4, you need to show the error message.

if (incorrectAttempts === 4) {
      errorMessage('Login blocked: Too many incorrect attempts');
      return;
}

}
}

// Do not change the line below
Expand Down
15 changes: 9 additions & 6 deletions task-3/converter.js
View file
Open in desktop
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You met all the requirements for Task 3 with only a very small improvement. Well done!

Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: ");
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
console.log("3: Display the current exchange rate");
const menuSelection = prompt("Select your option [1, 2 or 3]: ");

console.log("\n");

if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the error message, the logic should check if the inputted amount is a valid positive number:

eurAmountNum <= 0

console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -29,9 +30,11 @@ if (menuSelection === "1") {
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the error message, the logic should check if the inputted amount is a valid positive number:

usdAmountNum <= 0

console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');
const eurAmount = usdAmountNum / EUR_USD_RATE;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.');
}
} else if (menuSelection === "3") {
console.log(`The current exchange rate is 1 EUR = ${EUR_USD_RATE} USD.`)
} else {
console.log("Invalid selection. Please choose either 1 or 2.");
console.log("Invalid selection. Please choose either 1, 2 or 3.");
}
Loading