Skip to content

Mareh A. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mareh-aboghanem wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mareh A. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9078a
Complete week 2 assignments
mareh-aboghanem Jan 21, 2026
fbf3400
week 2 assignment after modifing task3
mareh-aboghanem Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions task-1/leap-year.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,15 @@ const prompt = promptSync();
// Step 1: prompt the user to enter a year
// Step 2: convert the user input to a number so we can perform calculations
// Step 3: Implement the logic

//Task 1 Mareh
let userInput = prompt('Enter the year: ');
let year = Number(userInput);
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you used variables with clear names. But since these are constant variables, meaning that they are not re-assigned a value, it is a good practice to use const instead of let. So that when a future developer reads this code, it is clear that these variables are constant and don't change.


if (isNaN(year) || year < 1 || year > 9999) {
console.log('Invalid year!');
} else if ((year % 400 === 0) || (year % 4 === 0 && year % 100 !== 0)) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you met all the required conditions. However, one improvement would be to follow the DRY principle. In programming, there is a principle called DRY (Don't Repeat Yourself). So, for example, you could create a variable called isLeapYear and reuse it. Also, this way, the code becomes more readable for the future. Like, for example:

const isLeapYear = (year % 4 === 0) && (year % 100 !== 0 || year % 400 === 0);

if (isLeapYear) {
  console.log(`Yes, ${year} is a leap year`);
} else {
  console.log(`No, ${year} is not a leap year`);
}

console.log('Yes, ' + year + ' is a leap year');
} else {
console.log('No, ' + year + ' is not a leap year');
}
14 changes: 11 additions & 3 deletions task-2/login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,17 @@ import { errorMessage, successMessage } from './app.js';
let incorrectAttempts = 0;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
// Use incorrectAttempts to track the number of failed attempts
if(incorrectAttempts >= 4) {
errorMessage('Login blocked: Too many incorrect attempts.');
return;
}
else if((username === 'admin' && password === 'Hack1234') || (username === 'user' && password === '7654321')) {
successMessage('Logged in successfully.');
}
else {
incorrectAttempts+=1;
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, you need to check if incorrectAttempts has reached 4. If it is 4, you need to show the error message.

if (incorrectAttempts === 4) {
      errorMessage('Login blocked: Too many incorrect attempts');
      return;
}

errorMessage('Incorrect credentials');
}
}

// Do not change the line below
Expand Down
20 changes: 12 additions & 8 deletions task-3/converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: ");
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
console.log("3: Display the current exchange rate");
const menuSelection = prompt("Select your option [1,2,or 3]: ");

console.log("\n");

if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
if (Number.isNaN(eurAmountNum) && eurAmountNum > 0) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your logic for checking if the inputted EUR amount is incorrect. You should check if the amount is NOT a positive number:

eurAmountNum <= 0

console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -26,12 +27,15 @@ if (menuSelection === "1") {
// USD to EUR
const usdAmountInput = prompt("Enter amount in USD: ");
const usdAmountNum = Number(usdAmountInput);
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
if (Number.isNaN(usdAmountNum) && usdAmountNum > 0) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the error message, the logic should check if the inputted amount is a valid positive number:

usdAmountNum <= 0

console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');
const eurAmount = usdAmountNum / EUR_USD_RATE;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.');
}
} else {
console.log("Invalid selection. Please choose either 1 or 2.");

} else if(menuSelection === "3") {
console.log("The current exchange rate is 1 EUR = " + EUR_USD_RATE + " USD.");
}else {
console.log("Invalid selection. Please choose either 1 or 2 ,or 3.");
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output is grammatically not correct. It should be: "Invalid selection. Please choose either 1, 2 or 3."

}
Loading