Skip to content

Baraah A. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebaraah wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Baraah A. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions task-1/leap-year.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,31 @@
import promptSync from 'prompt-sync';
const prompt = promptSync();


// Write your code here
// Guidance:
// Step 1: prompt the user to enter a year
let input = prompt('Enter a year: ');
// Step 2: convert the user input to a number so we can perform calculations
let year = Number(input);
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you used variables with clear names. But since these are constant variables, meaning that they are not re-assigned a value, it is a good practice to use const instead of let. So that when a future developer reads this code, it is clear that these variables are constant and don't change.


// Step 3: Implement the logic
if ( year < 1 || year > 9999 ){
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to check if the user input is a number. You can make use of a JavaScript function called isNaN(). Example usage: !isNaN(year).

console.log('Invalid year!');
}
else {

if (year % 400 === 0){
console.log('yes,' + year + ' is a leap year');
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details matter. The output should be Yes, <YEAR> is a leap year. With a capital Y for yes, and a space after the comma.

}
else if(year % 100 === 0){
console.log('No ,'+ year + ' is not a leap year');
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space before the comma. It needs to be after the comma.

}
else if(year % 4===0){
console.log('Yes,'+ year + ' is a leap year');
}
else {
console.log('No ,'+ year + ' is not a leap year');
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you met all the required conditions. However, one improvement would be to follow the DRY principle. In programming, there is a principle called DRY (Don't Repeat Yourself). So, in this case, for example, you could create a variable called isLeapYear and reuse it wherever needed. Also, this way you could avoid repeating the same console statement, and the code becomes more readable for the future. Like, for example:

const isLeapYear = (year % 4 === 0) && (year % 100 !== 0 || year % 400 === 0);

if (isLeapYear) {
  console.log(`Yes, ${year} is a leap year`);
} else {
  console.log(`No, ${year} is not a leap year`);
}

}
}
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling of the code matters. The code would be more readable if you have consistent indentations.





14 changes: 13 additions & 1 deletion task-2/login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,21 @@ import { errorMessage, successMessage } from './app.js';
let incorrectAttempts = 0;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
if (incorrectAttempts >= 4){
errorMessage('Login blocked: Too many incorrect attempts');
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have an independent if block, if the number of incorrect attempts is 4 or more, after showing the message, you need to return so the code doesn't continue executing. Otherwise, it will not show the correct message.

But if you use a single block, then it will show the correct message:

  if (incorrectAttempts >= 4) {
    errorMessage('Login blocked: Too many incorrect attempts');
  } else if (username === 'admin' && password === 'Hack1234') {
    successMessage('Logged in successfully');
  } else if (username === 'user' && password === '7654321') {
    successMessage('Logged in successfully');
  } else {
    incorrectAttempts++;
    errorMessage('Incorrect credentials');

    if (incorrectAttempts === 4) {
      errorMessage('Login blocked: Too many incorrect attempts');
      return;
    }
  }

}
if (username ==='admin' && password ==='Hack1234'){
successMessage('Logged in successfully');
}
else if (username ==='user' && password ==='7654321'){
successMessage('Logged in successfully');
}
// Use incorrectAttempts to track the number of failed attempts
else {
incorrectAttempts++;
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, you need to check if incorrectAttempts has reached 4. If it is 4, you need to show the error message.

if (incorrectAttempts === 4) {
      errorMessage('Login blocked: Too many incorrect attempts');
      return;
}

errorMessage('Incorrect credentials');
}
}

// Do not change the line below
Expand Down
16 changes: 10 additions & 6 deletions task-3/converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: ");
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
console.log("Display the current exchange rate");
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output should be 3: Display the current exchange rate

const menuSelection = prompt("Select your option [1 or 2 or 3]: ");

console.log("\n");

if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
if (Number.isNaN(eurAmountNum) || eurAmountNum <= 0) {
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catch! The input indeed should be a positive number (excluding 0).

console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -26,12 +27,15 @@ if (menuSelection === "1") {
// USD to EUR
const usdAmountInput = prompt("Enter amount in USD: ");
const usdAmountNum = Number(usdAmountInput);
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
if (Number.isNaN(usdAmountNum) || usdAmountNum <= 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');
const eurAmount = usdAmountNum / EUR_USD_RATE;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.');
}
} else if (menuSelection==="3"){
console.log("the current exchange rate is 1 EUR = "+ EUR_USD_RATE + "USD.")
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details matter. The output message should be case sensitive with correct spaces in place. It might be easier to use template literals:

console.log(`The current exchange rate is 1 EUR = ${EUR_USD_RATE} USD.`)


} else {
console.log("Invalid selection. Please choose either 1 or 2.");
Copy link

@mnvacym mnvacym Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output should be updated to reflect that you now have 3 options.

console.log("Invalid selection. Please choose either 1, 2 or 3.");

}
Loading