Skip to content

Monerh A #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Miuroro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Monerh A #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions task-1/leap-year.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,16 @@ import promptSync from 'prompt-sync';
const prompt = promptSync();


// Write your code here
// Guidance:
// Step 1: prompt the user to enter a year
// Step 2: convert the user input to a number so we can perform calculations
// Step 3: Implement the logic
let year = prompt("Enter a year: ");
year = Number(year);

if (Number.isNaN(year) || year <= 1 || year >= 9999) { // cheking for valid year input
console.log("Invalid year!");
}
else if ((year % 4 === 0 && year % 100 !== 0) || (year % 400 === 0)) {
console.log(" yes, "+ year + " is a leap year.");

}else if (year % 4 !== 0 || year % 100 === 0) { // added this to know what considered not a leap year
Copy link

@rafaelhdr rafaelhdr Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is working great and it is approved. But this last if is redundant. You could skip the if.

For example:

if (isLeapYear) {
  // do this
} else if (!isLeapYear) {
  // do that
}

The conditional is complementary, and it could be just else

if (isLeapYear) {
  // do this
} else {
  // do that
}

console.log(" no, "+ year + " is not a leap year.");
}

35 changes: 31 additions & 4 deletions task-2/login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,39 @@
import { errorMessage, successMessage } from './app.js';

let incorrectAttempts = 0;
let isblocked = false;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
// Use incorrectAttempts to track the number of failed attempts
}

if (isblocked) {
errorMessage("Login blocked: Too many incorrect attempts");
return; // Exit early if login is blocked
}


if (username === "admin" && password === "Hack1234") {
successMessage("Logged in successfully");
incorrectAttempts = 0;

} else if (username === "user" && password === "7654321") {
successMessage("Logged in successfully");
incorrectAttempts = 0;

} else {
incorrectAttempts++;
errorMessage("Incorrect credentials" + " failed attempt: " + incorrectAttempts);

}

if (incorrectAttempts >= 4) {
isblocked = true; // the login is now blocked
errorMessage("Login blocked: Too many incorrect attempts");


}

}


// Do not change the line below
export { onLogin };
17 changes: 11 additions & 6 deletions task-3/converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: ");
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
console.log("3: Display the current exchange rates");
const menuSelection = prompt("Select your option [1, 2 or 3]: ");

console.log("\n");

if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
if (Number.isNaN(eurAmountNum) || eurAmountNum <= 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -26,12 +27,16 @@ if (menuSelection === "1") {
// USD to EUR
const usdAmountInput = prompt("Enter amount in USD: ");
const usdAmountNum = Number(usdAmountInput);
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
if (Number.isNaN(usdAmountNum) || usdAmountNum <= 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');
const eurAmount = usdAmountNum / EUR_USD_RATE;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.');
}
} else if (menuSelection === "3") {
// Display exchange rates
console.log("The current exchange rate is 1 EUR = " + EUR_USD_RATE.toFixed(4) + " USD.");

} else {
console.log("Invalid selection. Please choose either 1 or 2.");
}
Loading