-
Notifications
You must be signed in to change notification settings - Fork 19
HannahN #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
HannahN #15
Changes from all commits
d7f08e6
25a8bf2
0ab9c5d
a1a2ff7
8156ae2
ab6b955
88e9994
ea400ed
5321ed8
eaf8ba6
b2582f5
74500af
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,3 +7,23 @@ const prompt = promptSync(); | |||||||||||||||||||||||||||||||||
| // Step 1: prompt the user to enter a year | ||||||||||||||||||||||||||||||||||
| // Step 2: convert the user input to a number so we can perform calculations | ||||||||||||||||||||||||||||||||||
| // Step 3: Implement the logic | ||||||||||||||||||||||||||||||||||
| let UserInput = prompt('Enter an year: '); | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| let year = Number(UserInput); | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| if(year<1 || year >9999 || isNaN(year)){ | ||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good job using |
||||||||||||||||||||||||||||||||||
| console.log('Invalid Year');} | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| else if(year % 400 === 0 ){ | ||||||||||||||||||||||||||||||||||
| console.log('Yes,' +year+' is a leap year'); | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| else if(year % 100 ===0 || !year % 4 ===0){ | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| console.log('no,' +year+' is not a leap year'); | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+21
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a small mistake in this part.
One more thing in this part, since that detials matters.
Comment on lines
+16
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One small style note: consistent indentation (spacing at the beginning of lines) makes the code easier to read. Try to align if / else blocks consistently.
Suggested change
|
||||||||||||||||||||||||||||||||||
| else{ | ||||||||||||||||||||||||||||||||||
| console.log('No,' +year+' is not a leap year'); | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,48 @@ import { errorMessage, successMessage } from './app.js'; | |
| let incorrectAttempts = 0; | ||
|
|
||
| function onLogin(username, password) { | ||
|
|
||
| // Write your code here. | ||
| // Use the variables 'username' and 'password' to access the input values | ||
| // Use incorrectAttempts to track the number of failed attempts | ||
|
|
||
| const validUsers =[ | ||
| {username : 'admin', password : 'Hack1234'}, | ||
| {username : 'user', password : 7654321} | ||
| ]; | ||
| if (incorrectAttempts >= 4){ | ||
| errorMessage('Login blocked: Too many incorrect attempts'); | ||
| return; | ||
| } | ||
|
|
||
| let foundCorrectUser = false; | ||
|
|
||
|
|
||
| if (username === validUsers[0].username && password === validUsers[0].password) { | ||
| foundCorrectUser = true; | ||
| } | ||
|
|
||
|
|
||
| if (username === validUsers[1].username && password === validUsers[1].password) { | ||
| foundCorrectUser = true; | ||
| } | ||
|
|
||
|
|
||
| if (foundCorrectUser === true) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small style note, what you wrote is correct. But you can also write it in another way: |
||
| incorrectAttempts = 0; | ||
| successMessage("Logged in successfully"); | ||
| } else { | ||
|
|
||
| incorrectAttempts = incorrectAttempts + 1; | ||
|
|
||
|
|
||
| if (incorrectAttempts >= 4) { | ||
| errorMessage("Login blocked: Too many incorrect attempts"); | ||
| } else { | ||
| errorMessage("Incorrect credentials"); | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| // Do not change the line below | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "dependencies": { | ||
| "prompt-sync": "^4.2.0" | ||
| }, | ||
| "type": "module" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,18 +5,19 @@ const prompt = promptSync(); | |
| const EUR_USD_RATE = 1.1643; | ||
|
|
||
| // Menu display | ||
| conole.log("Hello and welcome to the currency converter. Please choose: "); | ||
| console.log("Hello and welcome to the currency converter. Please choose: "); | ||
| console.log("1: Convert EUR to USD"); | ||
| console.log("2: Convert USD to EUR"); | ||
| const menuSelection = prompt("Select your option [1 or 2]: "); | ||
| console.log("3: Display the current exchange rate") | ||
| const menuSelection = prompt("Select your option [1 , 2 or 3]: "); | ||
|
|
||
| console.log("\n"); | ||
|
|
||
| if (menuSelection === "1") { | ||
| // EUR to USD | ||
| const eurAmountInput = prompt("Enter amount in EUR: "); | ||
| const eurAmountNum = Number(eurAmountInput); | ||
| if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) { | ||
| if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here you can also reject |
||
| console.log("Please enter a valid positive number for the amount."); | ||
| } else { | ||
| const usdAmount = eurAmountNum * EUR_USD_RATE; | ||
|
|
@@ -29,9 +30,13 @@ if (menuSelection === "1") { | |
| if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) { | ||
| console.log("Please enter a valid positive number for the amount."); | ||
| } else { | ||
| const eurAmount = usdAmountNum / eur_usd_rate; | ||
| const eurAmount = usdAmountNum / EUR_USD_RATE; | ||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.'); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here you are printing the USD amount twice. You should display the calculated EUR amount instead. |
||
| } | ||
| } else { | ||
| } | ||
| else if (menuSelection === "3"){ | ||
| console.log("The current exchange rate is 1 EUR = 1.1643 USD."); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small improvement: instead of hardcoding the exchange rate value, you could use the |
||
| } | ||
| else { | ||
| console.log("Invalid selection. Please choose either 1 or 2."); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here in line |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clear variable names. Since these variables are not reassigned, you could use
constinstead ofletto make that clearer. This is a small best-practice improvement.