-
Notifications
You must be signed in to change notification settings - Fork 19
Halyna R. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Halyna R. #14
Changes from all commits
211ce9d
5900a5e
0a6fb00
98b10fb
8fcda77
ba42a23
a87d1b5
fbbf339
b65742a
fcf34df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,17 @@ | ||
| import promptSync from 'prompt-sync'; | ||
| import promptSync from "prompt-sync"; | ||
| const prompt = promptSync(); | ||
|
|
||
| const input_year = prompt("Enter a year(1-9999): "); | ||
| const year = Number(input_year); | ||
|
|
||
| // Write your code here | ||
| // Guidance: | ||
| // Step 1: prompt the user to enter a year | ||
| // Step 2: convert the user input to a number so we can perform calculations | ||
| // Step 3: Implement the logic | ||
| if (!Number.isInteger(year) || year < 1 || year > 9999) { | ||
| console.log("Invalid year!"); | ||
| } else { | ||
| const isLeap = year % 400 === 0 || (year % 4 === 0 && year % 100 !== 0); | ||
|
|
||
| if (isLeap) { | ||
| console.log("Yes, " + year + " is a leap year"); | ||
| } else { | ||
| console.log("No, " + year + " is not a leap year"); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,35 @@ | ||
| // Do not change the line below | ||
| import { errorMessage, successMessage } from './app.js'; | ||
| import { showMessage } from './app.js'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you tried running this code in the browser? It no longer runs because you now need to import |
||
|
|
||
|
|
||
|
|
||
| let incorrectAttempts = 0; | ||
|
|
||
|
|
||
| function onLogin(username, password) { | ||
| // Write your code here. | ||
| // Use the variables 'username' and 'password' to access the input values | ||
| // Use incorrectAttempts to track the number of failed attempts | ||
| if (incorrectAttempts >= 4) { | ||
| showMessage("Login blocked: Too many incorrect attempts", "error"); | ||
| return; | ||
| } | ||
|
|
||
| // 2) check valid credentials | ||
| const isValid = | ||
| (username === "admin" && password === "Hack1234") || | ||
| (username === "user" && password === "7654321"); | ||
|
|
||
| if (isValid) { | ||
| showMessage("Logged in successfully", "success"); | ||
| incorrectAttempts = 0; | ||
| } else { | ||
| incorrectAttempts += 1; | ||
|
|
||
| // after increment, if now blocked -> show blocked (requirement 3+4) | ||
| if (incorrectAttempts >= 4) { | ||
| showMessage("Login blocked: Too many incorrect attempts", "error"); | ||
| } else { | ||
| showMessage("Incorrect credentials", "error"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Do not change the line below | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,18 +5,19 @@ const prompt = promptSync(); | |
| const EUR_USD_RATE = 1.1643; | ||
|
|
||
| // Menu display | ||
| conole.log("Hello and welcome to the currency converter. Please choose: "); | ||
| console.log("Hello and welcome to the currency converter. Please choose: ");//1 bug | ||
| console.log("1: Convert EUR to USD"); | ||
| console.log("2: Convert USD to EUR"); | ||
| const menuSelection = prompt("Select your option [1 or 2]: "); | ||
| console.log("3: Display the current exchange rate"); | ||
| const menuSelection = prompt("Select your option [1, 2 or 3]: "); | ||
|
|
||
| console.log("\n"); | ||
|
|
||
| if (menuSelection === "1") { | ||
| // EUR to USD | ||
| const eurAmountInput = prompt("Enter amount in EUR: "); | ||
| const eurAmountNum = Number(eurAmountInput); | ||
| if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) { | ||
| if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) {//2 bug | ||
| console.log("Please enter a valid positive number for the amount."); | ||
| } else { | ||
| const usdAmount = eurAmountNum * EUR_USD_RATE; | ||
|
|
@@ -29,8 +30,22 @@ if (menuSelection === "1") { | |
| if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) { | ||
| console.log("Please enter a valid positive number for the amount."); | ||
| } else { | ||
| const eurAmount = usdAmountNum / eur_usd_rate; | ||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.'); | ||
| const eurAmount = usdAmountNum / EUR_USD_RATE;//3 bug | ||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.'); | ||
| }} else if (menuSelection === "3") { | ||
| console.log(`The current exchange rate is 1 EUR = ${EUR_USD_RATE} USD.`); | ||
| } else if (menuSelection === "1") { | ||
| // EUR -> USD | ||
| const eurAmountInput = prompt("Enter amount in EUR: "); | ||
| const eurAmountNum = Number(eurAmountInput); | ||
|
|
||
| if (Number.isNaN(eurAmountNum) || eurAmountNum <= 0) { | ||
| console.log("Please enter a valid positive number for the amount."); | ||
| } else { | ||
|
Comment on lines
+37
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You already handled option 1 in the code above. |
||
| const usdAmount = eurAmountNum * EUR_USD_RATE; | ||
| console.log( | ||
| `${eurAmountNum.toFixed(2)} EUR is equal to ${usdAmount.toFixed(2)} USD.` | ||
| ); | ||
| } | ||
| } else { | ||
| console.log("Invalid selection. Please choose either 1 or 2."); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you add an option 3, it should also be reflected in the error message. |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what happened. This looks like an older version of the assignment that Stas has changed since. Did you make these changes?