-
Notifications
You must be signed in to change notification settings - Fork 19
Mustafa Homsi #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mustafa Homsi #11
Changes from all commits
36e7de9
43b4b21
ee8e416
48fb221
138a915
63b2c9b
313f896
4e79f04
4b7f672
1c85360
08369eb
c32004f
9c70222
de104e7
8468af8
0b93143
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
|
|
||
| { | ||
| "pass": true | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,16 @@ | ||
| import promptSync from 'prompt-sync'; | ||
| const prompt = promptSync(); | ||
|
|
||
| const prompt = promptSync(); | ||
| //step 1: ask the user for a year | ||
| const input = prompt("Enter a year: "); | ||
| //step 2: convert the input to a number | ||
| const year = parseInt(input); | ||
| //step 3: check if the year is a leap year | ||
| if (year < 1 || year > 9999 || isNaN(year)) { | ||
| console.log("Invalid input!"); | ||
| } else if ((year % 4 === 0 && year % 100 !== 0) || (year % 400 === 0)) { | ||
| console.log(`yes, ${year} is a leap year.`); | ||
| } else { | ||
| console.log(`no, ${year} is not a leap year.`); | ||
| } | ||
|
|
||
| // Write your code here | ||
| // Guidance: | ||
| // Step 1: prompt the user to enter a year | ||
| // Step 2: convert the user input to a number so we can perform calculations | ||
| // Step 3: Implement the logic | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,10 +4,21 @@ import { errorMessage, successMessage } from './app.js'; | |||||||||||||||||
| let incorrectAttempts = 0; | ||||||||||||||||||
|
|
||||||||||||||||||
| function onLogin(username, password) { | ||||||||||||||||||
| // Write your code here. | ||||||||||||||||||
| // Use the variables 'username' and 'password' to access the input values | ||||||||||||||||||
| // Use incorrectAttempts to track the number of failed attempts | ||||||||||||||||||
| if (incorrectAttempts >=4) { | ||||||||||||||||||
| errorMessage("login blocked: Too many incorrect attempts"); | ||||||||||||||||||
| return; | ||||||||||||||||||
| } | ||||||||||||||||||
| const isAdmin = username == "admin" && password == "Hack1234"; | ||||||||||||||||||
| const isUser = username == "user" && password == "7654321"; | ||||||||||||||||||
|
|
||||||||||||||||||
| if (isAdmin || isUser) { | ||||||||||||||||||
|
Comment on lines
+11
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use proper indentation, see https://hub.hackyourfuture.nl/Code-style-Basics-2b050f64ffc9807d912ed59b0c72440d
Suggested change
|
||||||||||||||||||
| successMessage("Logged in successfully"); | ||||||||||||||||||
| } else { | ||||||||||||||||||
| incorrectAttempts++; | ||||||||||||||||||
| errorMessage("Incorrect credentials"); | ||||||||||||||||||
| } | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| // Do not change the line below | ||||||||||||||||||
| export { onLogin }; | ||||||||||||||||||
| // task 2 complete | ||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,18 +5,19 @@ const prompt = promptSync(); | |||||
| const EUR_USD_RATE = 1.1643; | ||||||
|
|
||||||
| // Menu display | ||||||
| conole.log("Hello and welcome to the currency converter. Please choose: "); | ||||||
| console.log("Hello and welcome to the currency converter. Please choose: "); | ||||||
| console.log("1: Convert EUR to USD"); | ||||||
| console.log("2: Convert USD to EUR"); | ||||||
| const menuSelection = prompt("Select your option [1 or 2]: "); | ||||||
| console.log("3: Display the current exchange rate"); | ||||||
| const menuSelection = prompt("Select your option [1, 2 or 3]: "); | ||||||
|
|
||||||
| console.log("\n"); | ||||||
|
|
||||||
| if (menuSelection === "1") { | ||||||
| // EUR to USD | ||||||
| const eurAmountInput = prompt("Enter amount in EUR: "); | ||||||
| const eurAmountNum = Number(eurAmountInput); | ||||||
| if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) { | ||||||
| if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) { | ||||||
| console.log("Please enter a valid positive number for the amount."); | ||||||
| } else { | ||||||
| const usdAmount = eurAmountNum * EUR_USD_RATE; | ||||||
|
|
@@ -29,9 +30,11 @@ if (menuSelection === "1") { | |||||
| if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) { | ||||||
| console.log("Please enter a valid positive number for the amount."); | ||||||
| } else { | ||||||
| const eurAmount = usdAmountNum / eur_usd_rate; | ||||||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.'); | ||||||
| const eurAmount = usdAmountNum / EUR_USD_RATE; | ||||||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.'); | ||||||
| } | ||||||
| }else if (menuSelection === "3") { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| console.log("Current exchange rate: 1 EUR = " + EUR_USD_RATE.toFixed(4) + " USD"); | ||||||
| } else { | ||||||
| console.log("Invalid selection. Please choose either 1 or 2."); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You added an option 3, but your error message only mentions 1 or 2. |
||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind the casing: