Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .hyf/score.example.json

This file was deleted.

4 changes: 4 additions & 0 deletions .hyf/score.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

{
"pass": true
}
6 changes: 6 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 13 additions & 6 deletions task-1/leap-year.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
import promptSync from 'prompt-sync';
const prompt = promptSync();

const prompt = promptSync();
//step 1: ask the user for a year
const input = prompt("Enter a year: ");
//step 2: convert the input to a number
const year = parseInt(input);
//step 3: check if the year is a leap year
if (year < 1 || year > 9999 || isNaN(year)) {
console.log("Invalid input!");
} else if ((year % 4 === 0 && year % 100 !== 0) || (year % 400 === 0)) {
console.log(`yes, ${year} is a leap year.`);
} else {
console.log(`no, ${year} is not a leap year.`);
Comment on lines +12 to +14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind the casing:

Suggested change
console.log(`yes, ${year} is a leap year.`);
} else {
console.log(`no, ${year} is not a leap year.`);
console.log(`Yes, ${year} is a leap year.`);
} else {
console.log(`No, ${year} is not a leap year.`);

}

// Write your code here
// Guidance:
// Step 1: prompt the user to enter a year
// Step 2: convert the user input to a number so we can perform calculations
// Step 3: Implement the logic
17 changes: 14 additions & 3 deletions task-2/login.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,21 @@ import { errorMessage, successMessage } from './app.js';
let incorrectAttempts = 0;

function onLogin(username, password) {
// Write your code here.
// Use the variables 'username' and 'password' to access the input values
// Use incorrectAttempts to track the number of failed attempts
if (incorrectAttempts >=4) {
errorMessage("login blocked: Too many incorrect attempts");
return;
}
const isAdmin = username == "admin" && password == "Hack1234";
const isUser = username == "user" && password == "7654321";

if (isAdmin || isUser) {
Comment on lines +11 to +14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use proper indentation, see https://hub.hackyourfuture.nl/Code-style-Basics-2b050f64ffc9807d912ed59b0c72440d

Suggested change
const isAdmin = username == "admin" && password == "Hack1234";
const isUser = username == "user" && password == "7654321";
if (isAdmin || isUser) {
const isAdmin = username == "admin" && password == "Hack1234";
const isUser = username == "user" && password == "7654321";
if (isAdmin || isUser) {

successMessage("Logged in successfully");
} else {
incorrectAttempts++;
errorMessage("Incorrect credentials");
}
}

// Do not change the line below
export { onLogin };
// task 2 complete
13 changes: 8 additions & 5 deletions task-3/converter.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ const prompt = promptSync();
const EUR_USD_RATE = 1.1643;

// Menu display
conole.log("Hello and welcome to the currency converter. Please choose: ");
console.log("Hello and welcome to the currency converter. Please choose: ");
console.log("1: Convert EUR to USD");
console.log("2: Convert USD to EUR");
const menuSelection = prompt("Select your option [1 or 2]: ");
console.log("3: Display the current exchange rate");
const menuSelection = prompt("Select your option [1, 2 or 3]: ");

console.log("\n");

if (menuSelection === "1") {
// EUR to USD
const eurAmountInput = prompt("Enter amount in EUR: ");
const eurAmountNum = Number(eurAmountInput);
if (Number.isNaN(eurAmountNum) || eurAmountNum > 0) {
if (Number.isNaN(eurAmountNum) || eurAmountNum < 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const usdAmount = eurAmountNum * EUR_USD_RATE;
Expand All @@ -29,9 +30,11 @@ if (menuSelection === "1") {
if (Number.isNaN(usdAmountNum) || usdAmountNum < 0) {
console.log("Please enter a valid positive number for the amount.");
} else {
const eurAmount = usdAmountNum / eur_usd_rate;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + usdAmountNum.toFixed(2) + ' EUR.');
const eurAmount = usdAmountNum / EUR_USD_RATE;
console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.');
}
}else if (menuSelection === "3") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}else if (menuSelection === "3") {
} else if (menuSelection === "3") {

console.log("Current exchange rate: 1 EUR = " + EUR_USD_RATE.toFixed(4) + " USD");
} else {
console.log("Invalid selection. Please choose either 1 or 2.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added an option 3, but your error message only mentions 1 or 2.

}
Loading