Conversation
This comment has been minimized.
This comment has been minimized.
remarcmij
left a comment
There was a problem hiding this comment.
Hi @mohammedalfakih-dev, you did well on your first assignment. Please take note of some minor comments on the exact casing of the messages, as per the assignment.
On the second task, the streaks stats card doesn't show. As this sits on your GitHub welcome page, it would be nice of you fix this.
task-1/setup.sh
Outdated
| # Write your code here No newline at end of file | ||
| #!/usr/bin/env bash | ||
| set -e | ||
| echo "creating project.." |
There was a problem hiding this comment.
Details matter: the instructions specify the format of this string as "Creating project...". It should start with a capital C and end with three periods.
The autograding check currently ignores case and only checks the start of the string without the periods. In future, more stringent checks could flag this as an error.
task-1/setup.sh
Outdated
| mkdir src/profile | ||
| touch README.md | ||
| touch settings.conf | ||
| touch resources/family\ picture.jpg |
There was a problem hiding this comment.
Using a backslash to escape the space works fine. Alternatively, you could also quote the path argument that contains a space.
| touch resources/family\ picture.jpg | |
| touch "resources/family picture.jpg" |
task-1/setup.sh
Outdated
| git add . | ||
| git commit -m "Initial commit" | ||
| sleep 3 | ||
| echo "setup project..." |
| rmdir src/profile | ||
| rm resources/family\ picture.jpg | ||
| git add . | ||
| git commit -m "update readme and remove profile and family picture" |
task-1/setup.sh
Outdated
| git commit -m "update readme and remove profile and family picture" | ||
| sleep 3 | ||
| ls resources | ||
| echo "setup javascript" |
📝 HackYourFuture auto gradeAssignment Score: 71 / 100 ✅Status: ✅ Passed Test Details |
|
Thank you for the feedback |
No description provided.