Skip to content

Mohammed A#1

Open
mohammedalfakih-dev wants to merge 3 commits intoHackYourAssignment:mainfrom
mohammedalfakih-dev:main
Open

Mohammed A#1
mohammedalfakih-dev wants to merge 3 commits intoHackYourAssignment:mainfrom
mohammedalfakih-dev:main

Conversation

@mohammedalfakih-dev
Copy link

No description provided.

@github-actions

This comment has been minimized.

@remarcmij remarcmij self-assigned this Jan 15, 2026
Copy link

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mohammedalfakih-dev, you did well on your first assignment. Please take note of some minor comments on the exact casing of the messages, as per the assignment.

On the second task, the streaks stats card doesn't show. As this sits on your GitHub welcome page, it would be nice of you fix this.

task-1/setup.sh Outdated
# Write your code here No newline at end of file
#!/usr/bin/env bash
set -e
echo "creating project.."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details matter: the instructions specify the format of this string as "Creating project...". It should start with a capital C and end with three periods.

The autograding check currently ignores case and only checks the start of the string without the periods. In future, more stringent checks could flag this as an error.

task-1/setup.sh Outdated
mkdir src/profile
touch README.md
touch settings.conf
touch resources/family\ picture.jpg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a backslash to escape the space works fine. Alternatively, you could also quote the path argument that contains a space.

Suggested change
touch resources/family\ picture.jpg
touch "resources/family picture.jpg"

task-1/setup.sh Outdated
git add .
git commit -m "Initial commit"
sleep 3
echo "setup project..."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind the casing.

rmdir src/profile
rm resources/family\ picture.jpg
git add .
git commit -m "update readme and remove profile and family picture"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Message is descriptive.

task-1/setup.sh Outdated
git commit -m "update readme and remove profile and family picture"
sleep 3
ls resources
echo "setup javascript"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing

@github-actions
Copy link

📝 HackYourFuture auto grade

Assignment Score: 71 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details
======================= Task 1 =======================
▶️ Running setup.sh...
✅ Successfully executed setup.sh.
✅ Script ran for at least 6 seconds
✅ Path exists: project
✅ Path exists: project/README.md
✅ Path exists: project/settings.conf
✅ Path exists: project/resources
✅ Path exists: project/resources/icon.png
✅ Path exists: project/resources/logo.png
✅ Path exists: project/src
✅ Path exists: project/src/program.js
✅ Path exists: project/src/database
✅ Path exists: project/.git
✅ Path does not exist: project/resources/family picture.jpg
✅ Path does not exist: project/src/profile
✅ Path does not exist: project/src/program.java
❌ File content does not match: project/src/program.js
Expected: "console.log('JavaScript works!');"
Found:    "console.log("JavaScript works!");"
✅ File content is correct: project/README.md
✅ Output has: "Creating project"
✅ Output has: "Setup project"
✅ Output has: "Setup JavaScript"
✅ Output has: "JavaScript works!"
✅ Output has: "icon.png"
✅ Output has: "All done!"
✅ Found 3 commits
✅ First commit message is "initial commit"

======================= Task 2 =======================
Your GitHub username: mohammedalfakih-dev
▶️ Downloading profile README from: https://raw.githubusercontent.com/mohammedalfakih-dev/mohammedalfakih-dev/main/README.md
✅ Profile contains GitHub top languages widget
❌ Profile does not contain GitHub streaks widget
❌ Profile does not contain an animated title

======================= Summary =======================
- Task 1 Score: 94%
- Task 2 Score: 17%
Total Score: 71%
Min passing score: 50%

@mohammedalfakih-dev
Copy link
Author

Thank you for the feedback
I've updated the setup.sh file in task 1 as suggested and fixed the issues.
I also fixed the streak stats card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants