Vlad week1 React #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarlam
approved these changes
Sep 28, 2025
sarlam
left a comment
sarlam
left a comment
There was a problem hiding this comment.
Really well crafted! The way you separated the utils as well as the component will make it easier for you to iterate over this codebase and add features.
Comment on lines
+19
to
+24
| <Category | ||
| items={categoryItems} | ||
| activeCategory={selectedCategory} | ||
| onItemClick={setSelectedCategory} | ||
| /> | ||
| <Product items={filteredProducts} /> |
There was a problem hiding this comment.
Well done on separating the rendering in different component, it makes your code easier to maintain in the long run and easier to read as well
Comment on lines
+10
to
+14
| const [selectedCategory, setSelectedCategory] = useState("All"); | ||
|
|
||
| const categoryItems = ["All", ...categories]; | ||
|
|
||
| const filteredProducts = filterCategory(allProducts, selectedCategory); |
There was a problem hiding this comment.
If you want to go one step further, you could ask yourself how you would change this code to have the categories being toggles, or even, have multiple filters selected at the same time
Comment on lines
+48
to
+52
| .category-items.active { | ||
| background: #000000; | ||
| color: #fff; | ||
| border-color: #000000; | ||
| } |
There was a problem hiding this comment.
It would be a plus to change those values to be able to see which category is the selected one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reactvlaad.netlify.app/