Hanna_Dubyna-W2-Nodejs #15
Conversation
|
An important note: Unfortunately, I was not able to complete practice-exercise 2-party-time for week 2 due to the link to https://reservation100-sandbox.mxapps.io/rest-doc/api being unavailable at the moment. We asked Stas and I understand he is still working on it. |
| const API_KEY = "b2de7e3114f81132ea33a4b1f401206d"; | ||
|
|
||
| export default API_KEY; No newline at end of file |
There was a problem hiding this comment.
ℹ️ I don't think you were supposed to commit this, since now it means that anyone can use your API Key. I would go to the website and see if it's possible to refresh/invalidate this API Key to avoid it being used by others.
There was a problem hiding this comment.
Hello Henrique,
Thank you very much for checking and approving the assignment.
Regarding the key, I would like to fix it. Can I do the next:
- remore a file keys.js from the project with command
git rm --cached assignments/hackyourfuturetemperature/sources/keys.js - and then add a file keys.js to .gitignore
- and commit and push it?
Looking forward to your reply.
There was a problem hiding this comment.
Hello Henrique,
I made these changes. I would be very grateful if you can check.
The message of the commit is 'Untrack keys.js and update .gitignore'.
hacdias
left a comment
hacdias
left a comment
There was a problem hiding this comment.
Other than the comment about the API Key, everything else looks great :)
HannaInIT
force-pushed
the
Hanna_Dubyna-w2-Nodejs
branch
from
397f9bf to
6a4a0fd
Compare
2 participants
No description provided.