feat: Add What Happens Next, Winners & Losers, FAQ sections with Schema.org FAQPage and content depth validation by Copilot · Pull Request #1661 · Hack23/riksdagsmonitor

Copilot · 2026-04-10T09:09:40Z

github-actions · 2026-04-10T09:10:23Z

🏷️ Automatic Labeling Summary

This PR has been automatically labeled based on the files changed and PR metadata.

Applied Labels: size-xs

Label Categories

🗳️ Content: news, dashboard, visualization, intelligence
💻 Technology: html-css, javascript, workflow, security
📊 Data: cia-data, riksdag-data, data-pipeline, schema
🌍 I18n: i18n, translation, rtl
🔒 ISMS: isms, iso-27001, nist-csf, cis-controls
🏗️ Infrastructure: ci-cd, deployment, performance, monitoring
🔄 Quality: testing, accessibility, documentation, refactor
🤖 AI: agent, skill, agentic-workflow

For more information, see .github/labeler.yml.

github-actions · 2026-04-10T09:10:48Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…chema, and content depth validation Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/0ddc5fe4-4563-49ee-963e-b7e378213172 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-04-10T09:29:33Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…s and context requirements Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/0ddc5fe4-4563-49ee-963e-b7e378213172 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-04-10T09:34:51Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Adds richer, more structured article sections (timeline, actor outcomes, FAQ) to improve reader usefulness and SEO, and extends the quality enhancer to detect/validate presence and content depth for key sections.

Changes:

Introduces new editorial data types and quality metrics/thresholds (FAQ items, timeline entries, winners/losers entries, specific-claims + lede depth).
Extends article HTML templating with new section renderers and conditional Schema.org FAQPage JSON-LD + expanded speakable selectors.
Adds new editorial requirements/directives and new section transitions + section presence detection in the quality enhancer.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
scripts/types/validation.ts	Adds new quality thresholds and metrics fields for section presence and content depth.
scripts/types/editorial.ts	Defines structured types for What Happens Next, Winners/Losers, and FAQ items.
scripts/types/article.ts	Adds `faqItems` to `ArticleData` for rendering + structured data.
scripts/editorial-pillars.ts	Adds context-aware inter-section transition templates and generator.
scripts/editorial-framework.ts	Extends `EditorialSection` and updates required sections for specific article profiles.
scripts/article-template/template.ts	Emits conditional `FAQPage` JSON-LD and renders FAQ section; expands speakable selectors.
scripts/article-template/registry.ts	Adds AI directive factories and wires them into four article types.
scripts/article-template/index.ts	Re-exports and exposes new section generators from the template module.
scripts/article-template/helpers.ts	Implements HTML generators for timeline, winners/losers, and FAQ sections.
scripts/article-template/constants.ts	Adds localized titles/labels for the new sections across 14 languages.
scripts/article-quality-enhancer.ts	Adds detection for new sections and introduces specific-claims + lede-depth validation.

Copilot · 2026-04-10T10:06:18Z

scripts/article-quality-enhancer.ts

+function hasWinnersLosers(content: string): boolean {
+  const patterns: readonly RegExp[] = [
+    /class=["'][^"']*\bwinners-losers\b/,
+    /winners\s*[&and]+\s*losers/i,


The Winners & Losers detector regex /winners\s*[&and]+\s*losers/i is overly permissive because [&and]+ is a character class (matches any mix of '&', 'a', 'n', 'd'), which can trigger false positives (e.g. "winners n losers"). Use an alternation like (?:&|and) (and keep surrounding whitespace handling) to match only the intended separator.

Suggested change

/winners\s*[&and]+\s*losers/i,

/winners\s*(?:&|and)\s*losers/i,

Copilot · 2026-04-10T10:06:18Z

scripts/article-template/template.ts

+  <script type="application/ld+json">
+  {
+    "@context": "https://schema.org",
+    "@type": "FAQPage",
+    "mainEntity": [${(faqItems as FAQItem[]).map(item => `
+      {
+        "@type": "Question",
+        "name": "${escapeHtml(item.question)}",
+        "acceptedAnswer": {
+          "@type": "Answer",
+          "text": "${escapeHtml(item.answer)}"
+        }
+      }`).join(',')}
+    ]
+  }
+  </script>` : ''}


The FAQPage JSON-LD is built via string interpolation with escapeHtml(), but escapeHtml() does not JSON-escape newlines/backslashes. If an FAQ question/answer contains a newline (common in AI output), the resulting JSON-LD becomes invalid. Consider constructing the object and embedding it with JSON.stringify(...), or at least normalizing whitespace (similar to sanitizeArticleBody()) for question/answer fields before interpolating.

Suggested change

<script type="application/ld+json">

{

"@context": "https://schema.org",

"@type": "FAQPage",

"mainEntity": [${(faqItems as FAQItem[]).map(item => `

{

"@type": "Question",

"name": "${escapeHtml(item.question)}",

"acceptedAnswer": {

"@type": "Answer",

"text": "${escapeHtml(item.answer)}"

}

}`).join(',')}

]

}

</script>` : ''}

<script type="application/ld+json">${JSON.stringify({

'@context': 'https://schema.org',

'@type': 'FAQPage',

mainEntity: (faqItems as FAQItem[]).map(item => ({

'@type': 'Question',

name: item.question,

acceptedAnswer: {

'@type': 'Answer',

text: item.answer,

},

})),

}).replace(/</g, '\\u003c')}</script>` : ''}

Copilot · 2026-04-10T10:06:19Z

scripts/editorial-framework.ts

      'policy-mindmap',
      'deep-analysis',
      'watch-points',
+      'what-happens-next',
+      'winners-losers',
      'sources-methodology',


The PR description/title mention adding an FAQ section and adding it to requiredSections for these article types, but the updated requiredSections arrays here only add what-happens-next and winners-losers (no faq). Either add faq to the required sections for the intended profiles, or adjust the PR description/requirements so the gate matches the actual intent.

pethers · 2026-04-10T11:31:28Z

@copilot apply changes based on the comments in this thread

github-actions · 2026-04-10T11:32:21Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…age JSON-LD, add faq to requiredSections Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/a8a68e49-c93b-4008-aaae-b4b1fb9d9150 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-04-10T11:34:17Z

@copilot apply changes based on the comments in this thread

Applied all three review comments in bf2575f:

Regex fix (article-quality-enhancer.ts:217): Changed [&and]+ → (?:&|and) to prevent false positives like "winners n losers".
FAQPage JSON-LD (template.ts): Replaced escapeHtml() string interpolation with JSON.stringify() + \u003c escaping, so newlines/backslashes in AI-generated FAQ answers produce valid JSON-LD.
Missing faq in requiredSections (editorial-framework.ts): Added 'faq' to all four article types (committee-reports, propositions, motions, interpellations).

github-actions · 2026-04-10T11:35:07Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

pethers · 2026-04-10T15:05:59Z

@copilot apply changes based on the comments in this thread

…ments Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/08d4f7db-3936-4382-bbb7-21fafacfcc88 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-04-10T15:10:10Z

@copilot apply changes based on the comments in this thread

Applied in b0d08af:

Stack-based parser (countSectionWords): Replaced the simple regex (which terminated early on nested </div>/</section> tags) with a stack-based parser that tracks opening/closing tags and only stops at the true matching close tag.
Nested elements test: Added a focused test with nested <div> + <section> inside the target section — confirms all 8 words are counted correctly instead of stopping at the first inner </div>.

github-actions · 2026-04-10T15:10:46Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Copilot · 2026-04-10T15:47:08Z

scripts/article-template/helpers.ts

+  const rows = items
+    .filter(item => item.date && item.event)
+    .map(item => {
+      const sigClass = `significance-${item.significance}`;
+      const sigLabel = sigLabels[item.significance];
+      return `      <li class="timeline-item ${sigClass}">
+        <time class="timeline-date" datetime="${escapeHtml(item.date)}">${escapeHtml(item.date)}</time>
+        <span class="timeline-event">${escapeHtml(item.event)}</span>
+        <span class="timeline-significance" aria-label="${escapeHtml(sigLabel)}">${escapeHtml(sigLabel)}</span>
+      </li>`;


generateWhatHappensNextSection() builds CSS classes and looks up SIGNIFICANCE_LABELS using item.significance, but it never validates that the incoming value is one of high|medium|low. If the timeline items come from untyped/JSON/AI input, an unexpected value will produce a class like significance-undefined and an empty label. Consider filtering invalid significance values or defaulting to a safe value (e.g. medium) before rendering.

Copilot · 2026-04-10T15:47:09Z

scripts/article-template/helpers.ts

+  const rows = entries
+    .filter(e => e.actor && e.evidence)
+    .map(e => {
+      const outcomeClass = `outcome-${e.outcome}`;
+      const outcomeLabel = outcomeLabels[e.outcome];
+      return `      <li class="wl-entry ${outcomeClass}">
+        <span class="wl-actor">${escapeHtml(e.actor)}</span>
+        <span class="wl-outcome">${escapeHtml(outcomeLabel)}</span>
+        <span class="wl-evidence">${escapeHtml(e.evidence)}</span>
+      </li>`;


generateWinnersLosersSection() uses e.outcome to build outcome-${e.outcome} and to index OUTCOME_LABELS, but it doesn't guard against unexpected values at runtime (e.g. from parsed AI output). That can yield outcome-undefined and empty labels. Consider validating/normalizing outcome (wins/loses/mixed) or defaulting to mixed when unknown.

Copilot · 2026-04-10T15:47:09Z

scripts/article-quality-enhancer.ts

+  // Cap at 5 to prevent a heavily statistics-driven article from
+  // single-handedly satisfying the minSpecificClaims threshold via
+  // repetitive figures alone (e.g. budget tables with 20+ percentages).
+  const percentMatches = text.match(/\b\d+(?:\.\d+)?%/g);


Copilot · 2026-04-10T15:47:09Z

scripts/editorial-pillars.ts

+    .replace(/\{topic\}/g, topic)
+    .replace(/\{actor\}/g, actor);


generateSectionTransition() interpolates {topic}/{actor} using String.prototype.replace with a string replacement. In JS, replacement strings treat $ sequences specially (e.g. $&, $1), so a topicKeyword/actorName containing $ can be mangled. Use a replacer function (e.g. replace(/\{topic\}/g, () => topic)) or escape $ in the replacement values.

Suggested change

.replace(/\{topic\}/g, topic)

.replace(/\{actor\}/g, actor);

.replace(/\{topic\}/g, () => topic)

.replace(/\{actor\}/g, () => actor);

pethers · 2026-04-10T15:53:10Z

@copilot apply changes based on the comments in this thread

github-actions · 2026-04-10T15:54:00Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…r fn for $ safety Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/b49fb035-2d92-492a-a034-04a111679e8a Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-04-10T15:56:25Z

@copilot apply changes based on the comments in this thread

Applied all four review comments in 22c249b:

Significance validation (helpers.ts): generateWhatHappensNextSection() now validates item.significance against high|medium|low and defaults to medium for unknown values.
Outcome validation (helpers.ts): generateWinnersLosersSection() now validates e.outcome against wins|loses|mixed and defaults to mixed for unknown values.
Percentage comment fix (article-quality-enhancer.ts:337): Updated comment from "Percentage figures with surrounding context" to "Percentage figures" to match the actual regex behavior.
$ safety in replace (editorial-pillars.ts): Switched to replacer functions (() => topic / () => actor) so $ sequences in topic/actor values aren't mangled by JS replacement string semantics.

github-actions · 2026-04-10T15:57:21Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

pethers · 2026-04-10T16:00:05Z

@copilot analyse and fix root cause of TypeScript & JavaScript Testing / Unit Tests (Vitest) (pull_request)
TypeScript & JavaScript Testing / Unit Tests (Vitest) (pull_request)Failing after 1m

…s, and STEP 1 emphasis in news-evening-analysis.md Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/d35a12d5-b308-46ee-a102-7bc86c200799 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-04-10T16:08:46Z

@copilot apply changes based on the comments in this thread

Applied all four review comments in 22c249b:

Significance validation (helpers.ts): generateWhatHappensNextSection() now validates item.significance against high|medium|low and defaults to medium for unknown values.
Outcome validation (helpers.ts): generateWinnersLosersSection() now validates e.outcome against wins|loses|mixed and defaults to mixed for unknown values.
Percentage comment fix (article-quality-enhancer.ts:337): Updated comment from "Percentage figures with surrounding context" to "Percentage figures" to match the actual regex behavior.
$ safety in replace (editorial-pillars.ts): Switched to replacer functions (() => topic / () => actor) so $ sequences in topic/actor values aren't mangled by JS replacement string semantics.

@copilot analyse and fix root cause of [TypeScript & JavaScript Testing / Unit Tests (Vitest) (pull_request)](https://github.com/Hack23/riksdagsmonitor/actions/runs/24251762834/job/708...

Root cause: 3 pre-existing test failures in tests/agentic-workflow-mcp-queries.test.ts testing news-evening-analysis.md content — unrelated to this PR's changes (test file is identical to main). The workflow was missing:

STEP 1: ALWAYS check emphasis in MCP Health Gate section
supports from/tom / supports dateFrom/dateTo date annotation patterns
Numbered Example 1: / Example 2: cross-referencing examples and Cross-reference related data sources text

Fixed in 77027a3. All 55 MCP query tests + 88 workflow architecture tests + 39 content depth tests now pass.

github-actions · 2026-04-10T16:09:27Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Initial plan

62ab7b8

Copilot AI assigned Copilot and pethers Apr 10, 2026

github-actions bot added the size-xs Extra small change (< 10 lines) label Apr 10, 2026

Copilot started work on behalf of pethers April 10, 2026 09:11 View session

Copilot AI linked an issue Apr 10, 2026 that may be closed by this pull request

Improve News Article Content Quality — Editorial Templates & Article Structure (scripts/article-template/ + editorial) #1657

Closed

8 tasks

feat: add What Happens Next, Winners & Losers sections, FAQPage s…

34596bd

…chema, and content depth validation Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/0ddc5fe4-4563-49ee-963e-b7e378213172 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions bot added refactor Code refactoring size-l Large change (250-1000 lines) labels Apr 10, 2026

fix: add faq-section to speakable selectors, document claim count cap…

aa7739f

…s and context requirements Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/0ddc5fe4-4563-49ee-963e-b7e378213172 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Enhance article template and structure for better engagement~~ feat: Add What Happens Next, Winners & Losers, FAQ sections with Schema.org FAQPage and content depth validation Apr 10, 2026

Copilot AI requested a review from pethers April 10, 2026 09:35

Copilot finished work on behalf of pethers April 10, 2026 09:35

pethers marked this pull request as ready for review April 10, 2026 09:57

Copilot AI review requested due to automatic review settings April 10, 2026 09:57

Copilot started reviewing on behalf of pethers April 10, 2026 09:59 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Merge branch 'main' into copilot/improve-article-template-quality

decc48c

Copilot started work on behalf of pethers April 10, 2026 11:31 View session

Copilot finished work on behalf of pethers April 10, 2026 11:35

Copilot started work on behalf of pethers April 10, 2026 15:06 View session

fix: use stack-based parser in countSectionWords to handle nested ele…

b0d08af

…ments Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/08d4f7db-3936-4382-bbb7-21fafacfcc88 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers April 10, 2026 15:11

pethers requested a review from Copilot April 10, 2026 15:38

Copilot started reviewing on behalf of pethers April 10, 2026 15:40 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Merge branch 'main' into copilot/improve-article-template-quality

472b4e7

Copilot started work on behalf of pethers April 10, 2026 15:53 View session

fix: validate significance/outcome values, fix % comment, use replace…

22c249b

…r fn for $ safety Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/b49fb035-2d92-492a-a034-04a111679e8a Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers April 10, 2026 15:58

Copilot started work on behalf of pethers April 10, 2026 16:00 View session

github-actions bot added documentation Documentation updates workflow GitHub Actions workflows ci-cd CI/CD pipeline changes news News articles and content generation agentic-workflow Agentic workflow changes labels Apr 10, 2026

Copilot finished work on behalf of pethers April 10, 2026 16:09

pethers merged commit 3eada64 into main Apr 10, 2026
16 checks passed

pethers deleted the copilot/improve-article-template-quality branch April 10, 2026 16:13

	/winners\s[&and]+\slosers/i,
	/winners\s(?:&\|and)\slosers/i,

Conversation

Copilot AI commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 10, 2026

🏷️ Automatic Labeling Summary

Label Categories

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

pethers commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

pethers commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

pethers commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

pethers commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 10, 2026

Copilot AI commented Apr 10, 2026 •

edited

Loading

Copilot AI commented Apr 10, 2026 •

edited

Loading