refactor: decompose shared.ts and extract URL utils from generators.ts by Copilot · Pull Request #1658 · Hack23/riksdagsmonitor

Copilot · 2026-04-10T09:09:36Z

Split shared.ts (1,125 → 527 lines, -53%) into focused helper files
Extract URL utility functions from generators.ts into url-utils.ts
Maintain full backward compatibility via re-exports
Fix: import URL utils locally in generators.ts (re-export alone doesn't create local bindings)
Fix: Korean typo 외부 참照 → 외부 참조 in doc-type-helpers.ts
Fix: Chinese (zh) translation 외부参考 → 外部参考 in doc-type-helpers.ts (was mixed Korean+Chinese)
Fix: extend toGitHubRawUrl to handle /tree/ URLs, matching JSDoc
All 4,097 tests pass ✅
ESLint clean ✅

github-actions · 2026-04-10T09:10:21Z

🏷️ Automatic Labeling Summary

This PR has been automatically labeled based on the files changed and PR metadata.

Applied Labels: size-xs

Label Categories

🗳️ Content: news, dashboard, visualization, intelligence
💻 Technology: html-css, javascript, workflow, security
📊 Data: cia-data, riksdag-data, data-pipeline, schema
🌍 I18n: i18n, translation, rtl
🔒 ISMS: isms, iso-27001, nist-csf, cis-controls
🏗️ Infrastructure: ci-cd, deployment, performance, monitoring
🔄 Quality: testing, accessibility, documentation, refactor
🤖 AI: agent, skill, agentic-workflow

For more information, see .github/labeler.yml.

github-actions · 2026-04-10T09:10:45Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…move deprecated code - Split scripts/data-transformers/content-generators/shared.ts (1125 lines → 527 lines) into focused sub-modules: - doc-type-helpers.ts: DOC_TYPE_DISPLAY, localizeDocType, TITLE_SUFFIX_TEMPLATES - event-helpers.ts: findRelatedDocuments, findRelatedQuestions, extractMinister - impact-helpers.ts: generateImpactAnalysis, generateConsequencesAnalysis - framework-renderers.ts: stub types/functions + PESTLE/stakeholder/risk/implementation HTML renderers - ai-marker-helpers.ts: detectBannedPatterns + BANNED_PATTERNS - shared.ts kept as barrel that re-exports all previously-exported symbols for full backward compatibility; no existing imports were broken - Extract URL/text utilities from generators.ts (2234 → 2109 lines) to url-utils.ts: extractDocIdFromUrl, isGovernmentUrl, isGitHubUrl, toGitHubRawUrl, hashPathSuffix, sanitizePlainText; re-exported for BC - Types review: scripts/data-transformers/types.ts and scripts/generate-news-enhanced/types.ts have no duplicates with scripts/types/ — no consolidation needed - All 4097 tests pass, ESLint clean (no new errors) Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

…mework-renderers.ts Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-04-10T09:41:14Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Refactors the news/content generation scripts by extracting URL/text utility functions from the large generate-news-enhanced/generators.ts file and decomposing the monolithic data-transformers/content-generators/shared.ts into focused sub-modules while keeping existing import paths working via barrel re-exports.

Changes:

Added scripts/generate-news-enhanced/url-utils.ts and re-exported URL/text helpers from generators.ts.
Split scripts/data-transformers/content-generators/shared.ts into multiple helper modules (doc types, events, impact stubs, framework renderers, AI marker detection) and converted shared.ts into a barrel + deep-analysis host.
Moved framework “stub types/functions” and HTML renderers into framework-renderers.ts.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/generate-news-enhanced/url-utils.ts	New home for URL parsing + sanitization helpers used by deep-inspection generator.
scripts/generate-news-enhanced/generators.ts	Removes inline URL helper implementations and re-exports them from `url-utils`.
scripts/data-transformers/content-generators/shared.ts	Becomes a barrel re-exporter for extracted helpers while still hosting deep-analysis assembly.
scripts/data-transformers/content-generators/impact-helpers.ts	Extracts political impact & consequences AI_MUST_REPLACE stub generation.
scripts/data-transformers/content-generators/framework-renderers.ts	Extracts framework stub types/functions and HTML renderers for analysis sections.
scripts/data-transformers/content-generators/event-helpers.ts	Extracts keyword/event matching and minister extraction helpers.
scripts/data-transformers/content-generators/doc-type-helpers.ts	Extracts doc type localization table and title suffix templates.
scripts/data-transformers/content-generators/ai-marker-helpers.ts	Extracts banned-pattern detection used by quality gates.

Copilot · 2026-04-10T10:06:01Z

scripts/generate-news-enhanced/generators.ts

+// ---------------------------------------------------------------------------
+// URL & text utilities — implementation extracted to url-utils.ts
+// Re-exported here for backward compatibility.
+// ---------------------------------------------------------------------------
+export {
+  extractDocIdFromUrl,
+  isGovernmentUrl,
+  isGitHubUrl,
+  toGitHubRawUrl,
+  hashPathSuffix,
+  sanitizePlainText,
+} from './url-utils.js';


The functions re-exported from ./url-utils.js (e.g. extractDocIdFromUrl, isGovernmentUrl, etc.) are still referenced within this module, but an export { … } from … re-export does not create local bindings in the current file. This will cause TypeScript compile errors where these identifiers are used later in generators.ts. Import them explicitly (and then re-export if you want to keep the existing public API).

Copilot · 2026-04-10T10:06:01Z

scripts/data-transformers/content-generators/doc-type-helpers.ts

+    plural: {
+      en: 'External References', sv: 'Externa referenser', da: 'Eksterne referencer', no: 'Eksterne referanser',
+      fi: 'Ulkoiset viitteet', de: 'Externe Referenzen', fr: 'Références externes', es: 'Referencias externas',
+      nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참照', zh: '外部参考',


Korean plural translation for ext uses 외부 참照, which is a typo/inconsistent with the singular form (외부 참조). This will show incorrect text in the UI for Korean when pluralizing “External References”.

Suggested change

nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참照', zh: '外部参考',

nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참조', zh: '外部参考',

pethers · 2026-04-10T11:30:40Z

@copilot apply changes based on the comments in this thread and fix TypeScript & JavaScript Testing / Unit Tests (Vitest) (pull_request)
TypeScript & JavaScript Testing / Unit Tests (Vitest) (pull_request)Failing after 38s

github-actions · 2026-04-10T11:31:31Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

… doc-type-helpers.ts Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/dff320eb-d844-4f76-8ec0-f968ed2780c5 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-04-10T11:34:27Z

@copilot apply changes based on the comments in this thread and fix [TypeScript & JavaScript Testing...

Fixed both review comments in ae267a9:

generators.ts: Changed the export { … } from './url-utils.js' re-export to a proper import + separate export, so the URL utility functions are available as local bindings for use within the file.
doc-type-helpers.ts: Fixed Korean typo 외부 참照 → 외부 참조.

All 4,097 tests pass, ESLint clean.

github-actions · 2026-04-10T11:35:12Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Copilot · 2026-04-10T12:09:22Z

scripts/data-transformers/content-generators/doc-type-helpers.ts

+    plural: {
+      en: 'External References', sv: 'Externa referenser', da: 'Eksterne referencer', no: 'Eksterne referanser',
+      fi: 'Ulkoiset viitteet', de: 'Externe Referenzen', fr: 'Références externes', es: 'Referencias externas',
+      nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참조', zh: '외부参考',


The Chinese (zh) plural translation for document type ext is inconsistent/mistyped: it is set to 외부参考 (mix of Korean+Chinese). It should match the singular zh translation 外部参考 (or an appropriate Chinese plural form) to avoid user-facing i18n errors.

Suggested change

nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참조', zh: '외부参考',

nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참조', zh: '外部参考',

Copilot · 2026-04-10T12:09:23Z

scripts/generate-news-enhanced/url-utils.ts

+    const segments = parsed.pathname.split('/').filter(Boolean);
+    if (segments.length < 4) return null;
+
+    const [owner, repo, refType, ...rest] = segments;
+    if (refType !== 'blob' && refType !== 'raw') return null;


The JSDoc says this converts "blob/tree" GitHub URLs, but the implementation only accepts blob and raw (and returns null for /tree/ URLs). Either update the documentation to remove tree, or extend the implementation to handle tree/{branch}/{path} if that's intended.

Suggested change

const segments = parsed.pathname.split('/').filter(Boolean);

if (segments.length < 4) return null;

const [owner, repo, refType, ...rest] = segments;

if (refType !== 'blob' && refType !== 'raw') return null;

// or: /{owner}/{repo}/tree/{branch}/{...path}

const segments = parsed.pathname.split('/').filter(Boolean);

if (segments.length < 4) return null;

const [owner, repo, refType, ...rest] = segments;

if (refType !== 'blob' && refType !== 'raw' && refType !== 'tree') return null;

pethers · 2026-04-10T13:11:41Z

@copilot apply changes based on the comments in this thread

…tree URLs Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/4ac9d786-f068-4ebc-9b61-40abb31e209f Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-04-10T13:15:38Z

@copilot apply changes based on the comments in this thread

Fixed both review comments in 1b86b31:

doc-type-helpers.ts: Fixed Chinese (zh) plural translation from 외부参考 (Korean+Chinese mix) to 外部参考 (correct Chinese).
url-utils.ts: Extended toGitHubRawUrl to accept /tree/ URLs in addition to /blob/ and /raw/, matching the JSDoc.

All 4,097 tests pass, ESLint clean.

github-actions · 2026-04-10T13:16:32Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

github-actions · 2026-04-10T13:41:25Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Initial plan

7bfaf5a

Copilot AI assigned Copilot and pethers Apr 10, 2026

Copilot started work on behalf of pethers April 10, 2026 09:09 View session

Copilot AI linked an issue Apr 10, 2026 that may be closed by this pull request

Improve Code Architecture — Consolidate News Generation Modules & Reduce Complexity (scripts/ restructuring) #1654

Closed

9 tasks

github-actions bot added the size-xs Extra small change (< 10 lines) label Apr 10, 2026

Copilot AI and others added 2 commits April 10, 2026 09:33

fix: use double quotes for French string containing apostrophe in fra…

6941128

…mework-renderers.ts Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions bot added refactor Code refactoring size-xl Extra large change (> 1000 lines) labels Apr 10, 2026

Copilot AI changed the title ~~[WIP] Refactor news generation modules to reduce complexity~~ refactor: decompose shared.ts and extract URL utils from generators.ts Apr 10, 2026

Copilot AI requested a review from pethers April 10, 2026 09:40

Copilot finished work on behalf of pethers April 10, 2026 09:40

pethers marked this pull request as ready for review April 10, 2026 09:56

Copilot AI review requested due to automatic review settings April 10, 2026 09:56

Copilot started reviewing on behalf of pethers April 10, 2026 09:58 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Merge branch 'main' into copilot/refactor-news-generation-modules

f996a02

Copilot started work on behalf of pethers April 10, 2026 11:30 View session

fix: import URL utils locally in generators.ts and fix Korean typo in…

ae267a9

… doc-type-helpers.ts Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/dff320eb-d844-4f76-8ec0-f968ed2780c5 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers April 10, 2026 11:35

pethers requested a review from Copilot April 10, 2026 12:05

Copilot started reviewing on behalf of pethers April 10, 2026 12:05 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Copilot started work on behalf of pethers April 10, 2026 13:11 View session

fix: correct zh translation typo and extend toGitHubRawUrl to handle …

1b86b31

…tree URLs Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/4ac9d786-f068-4ebc-9b61-40abb31e209f Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers April 10, 2026 13:16

Merge branch 'main' into copilot/refactor-news-generation-modules

39df7fc

pethers requested a review from Copilot April 10, 2026 13:40

Copilot started reviewing on behalf of pethers April 10, 2026 13:42 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

pethers merged commit 497fde6 into main Apr 10, 2026
19 checks passed

pethers deleted the copilot/refactor-news-generation-modules branch April 10, 2026 14:06

	nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참照', zh: '外部参考',
	nl: 'Externe referenties', ar: 'مراجع خارجية', he: 'הפניות חיצוניות', ja: '外部参照', ko: '외부 참조', zh: '外部参考',

Conversation

Copilot AI commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 10, 2026

🏷️ Automatic Labeling Summary

Label Categories

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

pethers commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

pethers commented Apr 10, 2026

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions bot commented Apr 10, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 10, 2026 •

edited

Loading