feat: add masterclass panel and ATLAS masterclass landing page (close…#920
Open
rx18-eng wants to merge 1 commit into
Open
feat: add masterclass panel and ATLAS masterclass landing page (close…#920rx18-eng wants to merge 1 commit into
rx18-eng wants to merge 1 commit into
Conversation
Collaborator
Author
|
@EdwardMoyse Let me know your thoughts on this ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body
closes #835 and #915 in one PR. #835 was stale (branch drifted too far to rebase practically), so i rebuilt the masterclass code on a fresh branch from main instead.
what's in
uiConfig.showMasterclassPanel(default false so/atlasetc stay unchanged). tag particles, live invariant mass, results history./atlas-masterclassroute with a reduced bar. same atlas detector + event as/atlas. drops vr, ar, animate, clipping, overlay, share, make-picture. more info menu keeps info panel, event browser, eta-phi, kinematics (drops collections info + geometry browser).on()/emit()event bus onEventDisplay(addresses part of Allow easier integration of phoenix in other applications #826). standard events fired:particle-taggedparticle-untaggedresult-recordednot in (intentionally)
Recording.2026-06-02.002754.1.1.1.mp4