feat: add default outline to jets for better overlap visibility#837
Open
feat: add default outline to jets for better overlap visibility#837
Conversation
Signed-off-by: rx18-eng <remopanda78@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
When multiple jets overlap in the 3D view, it's hard to tell where one ends
and another begins since they're semi-transparent cones with similar colors.
This adds a lightweight wireframe edge outline to each jet using a low-poly
cylinder (12 segments), slightly brighter than the jet fill color. Makes it
much easier to distinguish overlapping jets.
The default outline automatically hides when hover or selection outlines are
active to avoid visual clutter, and comes back when deselected.
Also fixes a small bug in share-link where
getStateAsJSON()was renamed tosaveStateAsJSON().Files
phoenix-objects.ts— adds EdgesGeometry outline as a child of the jet mesheffects-manager.ts— toggles default outline visibility duringhover/selection
share-link-dialog.component.ts— fix renamed method call