feat: add configurable masterclass panel with event bus for external integration#835
Open
feat: add configurable masterclass panel with event bus for external integration#835
Conversation
…integration Signed-off-by: rx18-eng <remopanda78@gmail.com>
Author
|
Hey @EdwardMoyse @sponce , this account is my temporary replacement for my previous account remo-lab . |
Collaborator
|
Hi @rx18-eng, good to see you back ! I did not have time to look carefully to this PR yet, but I'll do it next week for sure. |
Author
|
Thanks @sponce for your review ! it really means a lot coming from you. I was honestly a bit worried due to the overnight GitHub situation, so I really appreciate your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #824 #826
Adds a configurable masterclass panel for tagging particles and computing
invariant masses, designed to be reusable across experiments.
What it does
Students can select tracks from any collection, tag them as particle types,
see kinematic values in a table, and compute invariant masses. Results can be
recorded across events and exported as a text file.
Architecture
The panel is experiment-agnostic. All experiment-specific details
(particle types, masses, hints, event classification) are defined in a
MasterclassConfiginterface and passed as an input — not hardcoded.MasterclassConfig— defines particle tags (id, symbol, color, mass),educational hints, and a classification callback
ATLAS_MASTERCLASS_CONFIG— default config for ATLAS Z-path exercises(e±/μ±/γ, Z/Higgs/J/ψ hints)
config object — no component changes
Integration API
A lightweight event bus (
on/emit) is added toEventDisplay, enablingexternal frameworks to subscribe to live data:
This allows external tools (e.g. histogram frameworks) to react to user
actions without modifying Phoenix.
Files
Core library (phoenix-event-display):
MasterclassConfig/ParticleTagDef types + ATLAS default config
UI components (phoenix-ui-components):
@input()
App (phoenix-app):
Test plan
Recording.2026-03-13.160329.mp4