Merged
Conversation
- Fix baseURL in production to use environment variable instead of window.location.origin - This prevents API calls from being intercepted by the static server - Update .env.production with proper configuration
- Add configurable REACT_APP_BASENAME for flexible deployment paths - Update BrowserRouter to use environment variable for basename - Fix wallet auth to use config.walletBaseURL instead of hardcoded URLs - Remove .env.production from tracking and add .env.production.example - Reset .env.development to localhost URLs for development
- Preserve all original content and credits - Add detailed architecture explanation with ASCII diagrams - Document reverse proxy benefits and setup rationale - Provide step-by-step installation and deployment guides - Include both reverse proxy and direct access scenarios - Add environment configuration examples and explanations - Document ngrok tunneling setup with custom domain support - Add comprehensive troubleshooting section - Include security considerations and best practices - Maintain respect for original authors and template credits
Maphikza
requested review from
AnthonyMarin,
ColbySerpa and
f7f376a1fcd0d0e11a10ed1b6577c9
Member
|
Great ReadMe! Everything is working great on my end. I'm a little unable to test the changes to the wallet URL right now, but the changes read just fine. |
AnthonyMarin
approved these changes
Jul 3, 2025
…-and-personal-mode
- Replace reference to external hornet_services_updated.conf file - Add complete nginx configuration example directly in README - Include WebSocket support, health checks, and all service routing - Remove dependency on external configuration files - Users can now follow setup instructions completely self-contained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Production Build API Configuration and Add Comprehensive Setup Documentation
Key Changes
Production Build Fixes:
window.location.originREACT_APP_BASENAMEfor flexible deployment paths.env.production.exampletemplate and remove.env.productionfrom trackingSetup Documentation:
Technical Details
REACT_APP_BASENAMETesting
Resolves production deployment issues and provides clear setup instructions for new users.