Removed duplicate of '/v1' in uri on topic subscribing and unsubcribing#1
Open
almliden wants to merge 1 commit intoHMS-Core:masterfrom
Open
Removed duplicate of '/v1' in uri on topic subscribing and unsubcribing#1almliden wants to merge 1 commit intoHMS-Core:masterfrom
almliden wants to merge 1 commit intoHMS-Core:masterfrom
Conversation
HMSPushKit
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing duplicate of
/v1in URI when subscribing/unsubscribing to a topic.When configuring
AGConnectAppwithApiBaseUrithe default value of the URI already contains/v1, and since it was present in the URI:s methodsSubscribeToTopicAsyncandUnsubscribeFromTopicAsyncwe were left with duplicates which points us to the wrong resource, eg[...]/v1/v1/[ClientId]/subscribe:topic.This fix removes the duplicate of
/v1to point us to the correct resource.