Open
Conversation
EricOnFHIR
reviewed
Oct 19, 2023
Collaborator
EricOnFHIR
left a comment
EricOnFHIR
left a comment
There was a problem hiding this comment.
Some non-trivial questions we should discuss.
| @@ -105,10 +120,9 @@ FHIRcast supports all events that follow this format. The most common events def | |||
|
|
|||
| #### Infrastructure events | |||
Collaborator
There was a problem hiding this comment.
Should UserHubernate and UserLogout events be here?
| Upon communicating a `SyncError` resulting from an unresponsive Subscriber, the Hub SHALL unsubscribe the Subscriber. | ||
|
|
||
| The Hub SHALL NOT generate [`SyncError`](3-2-1-SyncError.html) events in the following situations: | ||
| The Hub SHALL NOT generate [`syncerror`](3-2-1-SyncError.html) events in the following situation: |
Collaborator
There was a problem hiding this comment.
Shouldn't this be "SyncError" to be consistent with the sentences immediately above?
| * Does a Hub send an `SyncError` for each Subscriber that cannot be reached or refused, or is the Hub allowed to combine them in one. | ||
| * When the Hub/Subscriber resends an context change event, is the `Heartbeat.html` still needed? | ||
| * Should a Subscriber get all syncerror's or only those related to events to which it subscribed? | ||
| * Does a Hub send an `syncerror` for each Subscriber that cannot be reached or refused, or is the Hub allowed to combine them in one. |
Collaborator
There was a problem hiding this comment.
Confused about which we are going for: "SyncError" or "syncerror".
In 2.5.5, most of the occurrences are SyncError; however, here it seems like it was consciously changed to syncerror.
| **Anchor Context** | a context that is used as a container for shared content, typical anchor contexts are FHIR resources such as `ImagingStudy` and `DiagnosticReport` | ||
|
|
||
| **Anchor Context** | a context that is used as a container for shared content, typical anchor contexts are FHIR resources such as Patient, Encounter, ImagingStudy, and DiagnosticReport | ||
| **Anchor resource** | a FHIR resource that is used as a container for shared content, typical anchor resource are resources such as Patient, Encounter, ImagingStudy, and DiagnosticReport |
Collaborator
There was a problem hiding this comment.
Why is there an Anchor resource? I thought throughout the spec we were using Anchor Context and it was fine. For what is Anchor resource used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformat event definition section and added specifiaction language on the names of keys in context-change events.