Skip to content

Ensure all nan-slice warnings are caught #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psavery merged 1 commit into from
Feb 25, 2026
Merged

Ensure all nan-slice warnings are caught #1941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions hexrdgui/calibration/polarview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

from hexrd.rotations import mapAngle
from hexrd.utils.decorators import memoize
from hexrd.utils.warnings import ignore_warnings

from hexrd import constants as ct
from hexrd.xrdutil import _project_on_detector_plane, _project_on_detector_cylinder
from hexrd import instrument
Expand Down Expand Up @@ -519,13 +517,15 @@ def apply_intensity_corrections(self, img: np.ndarray) -> np.ndarray:

stacked = np.ma.stack(output.values()).filled(np.nan)

# It's okay to have all nan-slices here, but it produces a warning.
# Just ignore the warning.
with ignore_warnings(RuntimeWarning):
# In case there are overlapping detectors, we do nanmean for
# the intensities instead of nansum. This would produce a
# somewhat more reasonable intensity.
correction_field = np.nanmean(stacked, axis=0)
# In case there are overlapping detectors, we do nanmean for
# the intensities instead of nansum. All-NaN slices are expected
# (detector gaps) and should produce NaN in the correction field.
# We compute the mean manually instead of calling np.nanmean()
# because the "Mean of empty slice" RuntimeWarning it emits could
# not be reliably suppressed on all platforms (see PR #1941).
valid_count = np.sum(~np.isnan(stacked), axis=0)
with np.errstate(invalid='ignore', divide='ignore'):
correction_field = np.nansum(stacked, axis=0) / valid_count

img *= correction_field

Expand Down
Loading