Fix 10 - Avoid storing all scenes in memory before export#11
Open
apausa wants to merge 26 commits into
Open
Conversation
apausa
changed the title
apausa
changed the title
kjvbrt
reviewed
May 27, 2026
| } catch (error) { | ||
| console.error(`ERROR: ${error.message}`); | ||
| console.error(` | ||
| ERROR: ${error.message} |
Collaborator
There was a problem hiding this comment.
ERROR and CAUSE will show the same message?
Contributor
Author
There was a problem hiding this comment.
My bad, it should say error.cause so that it captures the errors in index.ts, whereas error.message captures the errors in cli.js.
kjvbrt
reviewed
May 27, 2026
| `INFO: Exporting the full geometry at the default traversal depth 2. Use a config when you need to:\n | ||
| - Hide parts: exclude specific volumes from the output\n | ||
| - Group volumes: combine multiple volumes into a single named view\n | ||
| `INFO: Exporting the full geometry at the default traversal depth 2. Use a config when you need to: |
Collaborator
There was a problem hiding this comment.
Will the new lines be preserved in the INFO message?
Contributor
Author
There was a problem hiding this comment.
Yes because the string uses the ``` quote.
kjvbrt
reviewed
May 27, 2026
Collaborator
There was a problem hiding this comment.
polyfilling is no longer needed?
Contributor
Author
There was a problem hiding this comment.
It is, but I turned it into a function which is called in index.ts so that its usage is more evident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
countRootObjectsfunction as they are already counted later on.installPolyfillsandnormalizePivotfunctions.