This repository was archived by the owner on Mar 12, 2019. It is now read-only.
Prepare global runkey #421
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global runkey is useful for taking calibration events during interfill, instead of local health check runs.
The idea is to have two and only two runkeys:
collisionandcosmicfor HCAL in LV0, which corresponds to two runkey names in the Grand Mastersnipept.Since
RUN_KEYcomes withconfigurecommand in global, we will stop supportingmaskedappsin the runkey like in local runs (maskedFMsalready replaced byFEDmasking). In principle, we could still implement apps masking by disabling the apps in supervisor since we don't have excessive inter-FM connections for global configurations. But the use case formaskedappsis rare and will be quite confusing.Therefore, in global, LV1 will have no selected runkey/mastersnippets during
initActionand will only receive them from LV0 and pass them to LV2s duringconfigueAction