Skip to content

Conversation

@Deledrius
Copy link
Member

Adds a Warp Message node for use in advanced logic trees.

This node requires an object position, and sends a message to warp there to the object specified by a PlasmaSceneObjectMsgRcvrNode.

@Deledrius Deledrius requested a review from Hoikas July 24, 2020 09:22
("receivers", {
"text": "Send To",
"type": "PlasmaWarpMessageSocket",
"valid_link_sockets": {"PlasmaWarpMessageSocket", "PlasmaNodeSocketInputGeneral"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"PlasmaNodeSocketInputGeneral"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the explanation in IRC, it might be better to use valid_link_nodes instead and specify the expected node type.

msg = plWarpMsg()
msg.BCastFlags |= plMessage.kNetPropagate
msg.warpFlags |= plWarpMsg.kFlushTransform
msg.transform = utils.matrix44(self.pos_object.matrix_local)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be more useful if pos_object were optional and defaulted to the pose of the object the tree is attached to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a useful default. I'll give it a try and see how that works in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants