Feat#2 jisoo/calendar#6
Open
seojisoosoo wants to merge 44 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
💙 작업 내용
✅ PR Point
완전! 쓸애기 코드! 이렇게 할 수도 있겠구나 정도로만 봐주세요!!! 컴포넌트 분리도 너무너무 안 되었고, 라이브러리를 뜯어고치느라고 애만 먹은 코드입니다ㅠㅠ 쓸애기!
react-calendarreact-ios-time-picker라이브러리 이용했습니다Date 객체를 string 형식으로 변경할 때에는
moment(value).format("YYYY-MM-DD")와 같은 방법을 사용했습니다. toIOString()메소드를 이용해보기도 했는데, 자꾸 하루 전 날짜로 찍히더라고요...! 그래서 moment 이용했습니다! (import moment from "moment"; 필요!)react-calendar에서 한칸한칸을 tile이라고 하더라고요! 내가 가진 수업데이터를 map돌리고 그 중에서도 날짜가 현재 날짜와 동일하면 html이라는 배열에 해당 태그를 넣어주는 방식으로 구현하였습니다.
😡 Trouble Shooting
<div id="root">바깥에 생성이 된다는 뜻입니다,,,기본적으로<div id="root">안쪽에 모든 로직이 생성되는 리액트의 방식을 거스르는 느낌이었어요...👀 스크린샷 / GIF / 링크
2023-07-04.7.05.04.mov
📚 Reference
react-ios-time-picker