Skip to content

Conversation

@tukanos
Copy link

@tukanos tukanos commented Aug 6, 2025

  • Even when loading Zinc using filetree:// referencing its own github path causes the next library after Zinc to load from github not from filetree. The next library could be e.g. Parasol or Seaside.

  • The reference to itself seems to be superfluous. If the library would be loaded using Metacello, then the repository is defined using #repository: which, in case github is used, will reference to it anyways.

tukanos added 2 commits August 6, 2025 10:02
- Even when loading Zinc using `filetree://` referencing its *own github path* causes the next library after Zinc to load from github *not* from filetree. The next library could be e.g. Parasol or Seaside.

- The reference to itself seems to be superfluous.  If the library would be loaded using Metacello, then the repository is defined using #repository: which, in case github is used, will reference to github anyways.
Replacing Monticello  with Metacello.

Updating the repository reference from http://seaside.gemtalksystems.com/ss/PharoCompat to github://GsDevKit/PharoCompatibility:master/repository.
@dalehenrich
Copy link
Member

@tukanos, could you make a neutral commit on tukanos:patch-1 ... that new commit will trigger the CI action to be run ... thanks!

The automated run of CI actions was disabled by github a while back and we didn't notice ... we've re-enabled CI runs and we need a new commit to trigger the action ...

@dalehenrich
Copy link
Member

@tukanos ... please hold off that commit ... I enabled the CI actions and they are hanging for PR #113 ... the jobs are not starting so the issue has nothing to do with your submission ...

@dalehenrich
Copy link
Member

dalehenrich commented Aug 7, 2025

@tukanos ... I've cleaned up the CI tests and now only the ZnClientTest>>testQueryGoogle test is failing ... and I think that Google may have deprecated or ??? the url/service being used by the test ... so if you could do a commit on both of your PRs we'll be able to ensure that the CI tests are passing ... thanks.

@tukanos
Copy link
Author

tukanos commented Aug 8, 2025

@tukanos, could you make a neutral commit on tukanos:patch-1 ... that new commit will trigger the CI action to be run ... thanks!

The automated run of CI actions was disabled by github a while back and we didn't notice ... we've re-enabled CI runs and we need a new commit to trigger the action ...

@dalehenrich I did neutral patch on tukanos:patch-1. Also added both patches on that branch also merged your GSDevKit\zinc gs_master into it. I hope that is what you need. I did not a new PR from tukanos:patch1. I hope that is what you need :). Thank you for fixing the CI so we can check it.

@kurtkilpela kurtkilpela merged commit 168be58 into GsDevKit:gs_master Aug 11, 2025
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants