Skip to content

feat[dace][next] Updated gt_inline_nested_sdfg()#2385

Merged
philip-paul-mueller merged 6 commits intoGridTools:mainfrom
philip-paul-mueller:deterministic_inlining
Jan 16, 2026
Merged

feat[dace][next] Updated gt_inline_nested_sdfg()#2385
philip-paul-mueller merged 6 commits intoGridTools:mainfrom
philip-paul-mueller:deterministic_inlining

Conversation

@philip-paul-mueller
Copy link
Copy Markdown
Contributor

@philip-paul-mueller philip-paul-mueller commented Nov 11, 2025

The PR changes how the function works:

  • The processing of them is now performed in a deterministic way.
    This is done by changing to a recursive scheme, where the nodes are first ordered and then processed.
  • The multistate flag was removed, since it was ignored.
  • The progress flag was removed, because it no longer make sense.

ToDo:

The main changes are:
- The processing of them is now performed in a deterministic way.
- The `multistate` flag was removed, since it was ignored.
- The `progress` flag was removed, because it no longer make sense.
@philip-paul-mueller
Copy link
Copy Markdown
Contributor Author

Performance looks okay:

bench_blueline_stencil_compute

Copy link
Copy Markdown
Contributor

@edopao edopao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some minor comments.

Comment thread src/gt4py/next/program_processors/runners/dace/transformations/simplify.py Outdated
Comment thread src/gt4py/next/program_processors/runners/dace/transformations/simplify.py Outdated
Comment thread src/gt4py/next/program_processors/runners/dace/transformations/simplify.py Outdated
Copy link
Copy Markdown
Contributor

@edopao edopao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philip-paul-mueller philip-paul-mueller merged commit ecab48e into GridTools:main Jan 16, 2026
23 checks passed
edopao added a commit to edopao/gt4py that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants