Skip to content

Fix Race Condition in SearchBar#458

Merged
clackner-gpa merged 4 commits intomasterfrom
SearchBar_Fixes
Apr 2, 2026
Merged

Fix Race Condition in SearchBar#458
clackner-gpa merged 4 commits intomasterfrom
SearchBar_Fixes

Conversation

@prestoncraw
Copy link
Copy Markdown
Contributor

@prestoncraw prestoncraw commented Mar 27, 2026 •
edited
Loading

  • Reworked SearchBar to use internalFilters as a single source of truth instead of a memo, with a single effect that builds the combined filters and pushes them to the parent
  • Add icons that will be used in future plot rework

clackner-gpa
clackner-gpa requested changes Mar 27, 2026
View reviewed changes
Comment thread react-interactive/src/SearchBar/SearchBar.tsx Outdated
@clackner-gpa clackner-gpa merged commit 8a495e0 into master Apr 2, 2026
4 checks passed
@clackner-gpa clackner-gpa deleted the SearchBar_Fixes branch April 2, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clackner-gpa clackner-gpa clackner-gpa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prestoncraw @clackner-gpa