Conversation
|
👋 @fschloesser would be awesome to get these improvements in :) |
GregorCH
reviewed
Nov 15, 2023
ipet/TestRun.py
Outdated
| """ Print data to console | ||
| """ | ||
| if (all_rows): | ||
| pd.set_option('display.max_rows', None) |
Owner
There was a problem hiding this comment.
I find this change a bit too intrusive. Also, I don't see the benefit: I thought that the two removed lines further down take care of displaying all rows. The change you suggest could be executed in ipet-parse directly, with no need to introduce this argument down through all involved methods.
Collaborator
Author
There was a problem hiding this comment.
Happy enough to take this out
Owner
|
If this problem mentioned is resolved, I am happy to accept. I never really got to look at the restructured text documentation, so any improvements are appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some small improvements