Skip to content

Conversation

@super-dm3
Copy link
Contributor

@super-dm3 super-dm3 commented Nov 6, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

:nth-child(n+B) selects only B-th elements

What is the new behavior?

:nth-child(n+B) selects B-th and all following elements
See: https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#nth-childn7

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.30%. Comparing base (6f8813c) to head (aab738e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #56      +/-   ##
============================================
+ Coverage     89.28%   89.30%   +0.01%     
- Complexity     1349     1350       +1     
============================================
  Files            26       26              
  Lines          3127     3131       +4     
============================================
+ Hits           2792     2796       +4     
  Misses          335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 added the bug Something isn't working label Nov 7, 2024
@jakejackson1 jakejackson1 merged commit aab738e into GravityPDF:main Nov 7, 2024
11 checks passed
@jakejackson1
Copy link
Member

Thanks for the well-formatted PR @super-dm3! This looks good to me. I made some very minor tweaks and merged it into main. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants