-
Notifications
You must be signed in to change notification settings - Fork 19
Playwright tests #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jakejackson1
wants to merge
57
commits into
hot-patch
Choose a base branch
from
playwright-tests
base: hot-patch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Playwright tests #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hot-patch #1625 +/- ##
=============================================
+ Coverage 92.72% 92.90% +0.17%
=============================================
Files 58 58
Lines 1526 1508 -18
Branches 420 415 -5
=============================================
- Hits 1415 1401 -14
+ Misses 103 102 -1
+ Partials 8 5 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ee5f60 to
4c94e22
Compare
5d360cc to
cd71757
Compare
When the PDF tmp directory is moved to a shared folder – like the top-level `tmp` folder – permission errors can occur. Add extra error handling for this use-case.
Guard against arrays when checking `page` and `subview` URL params in admin area
The EE_Front_Controller::get_request runs on the `parse_request` hook with a priority of 1. For whatever reason, this hook also removes itself when it runs. Under specific circumstances, WordPress will skip hooks on priority 10 due to this removal. To workaround this bug this PR moves our own `parse_request` hooks to priority 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert testcafe E2E tests into playwright E2E tests
Testing instructions
Screenshots
Checklist:
Additional Comments