Fix Text tool clearing text when hitting Escape by changing it to commit the edit instead#2052
Merged
Keavon merged 2 commits intoOct 26, 2024
Conversation
0HyperCube
approved these changes
Oct 20, 2024
0HyperCube
left a comment
0HyperCube
left a comment
Contributor
There was a problem hiding this comment.
This works as requested. Thanks you for taking the time to make this contribution.
Keavon
force-pushed
the
text-tool-esc-commits-text
branch
from
1a8c005 to
04b63f1
Compare
Keavon
changed the title
Member
|
Hi @RyanRothweiler, thanks again for this code contribution to the project! We're still hoping you will respond to the request to relicense this code. Please see #4208 ASAP, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2051
Text tool escape input now sends CommitText instead of abort.