Support beginning a video recording with the microphone muted#553
Open
drift8797 wants to merge 1 commit intoGrapheneOS:mainfrom
Open
Support beginning a video recording with the microphone muted#553drift8797 wants to merge 1 commit intoGrapheneOS:mainfrom
drift8797 wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the app is using CameraX 1.5, it is possible to set an initial muted state when recording a video. This PR makes it so that the microphone mute icon displays at all times in video mode, unless the Include Audio toggle is disabled.
Unlike Include Audio, this setting does not persist. This makes it useful as a quicker way to disable audio for a one-off recording or to start a recording muted and unmute audio only at a later time.
One downside compared to disabling Include Audio is that an audio track is always included regardless of whether the microphone was ever unmuted (it will be completely silent if muted for the entire recording). For videos meant to not have any audio, this uses additional storage and might display differently in some players, so I don't think this should replace the Include Audio toggle.