Type hint improvements #306
Open
+61
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `P` and `T` ParamSpec and TypeVar attributes are bound and indicate the parameters of the *wrapper* function, not the *wrapped* function. Signed-off-by: Stephen Finucane <stephen@that.guru>
…er.__get__ Properly handle method binding by providing overrides that will strip the self/cls parameter when used on a method rather than a parameter. Tests are updated to reflect this improvement. Signed-off-by: Stephen Finucane <stephen@that.guru>
Owner
|
What is The type hints are the way they are because a more simplified approach doesn't work with various type checkers and results in various cases being flagged as problems when they aren't. Would also have been helpful to see how you are using type hints in your usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were spotted while working on adding type hints to debtcollector. I believe the simplified types are correct, as evidenced by me no longer needing
type: ignorestatements in debtcollector plus the reduced failures in the tests, but this should definitely receive the twice-over.