Skip to content

feat(Combobox, Input): added autocomplete prop [run-chromatic]#710

Open
amandac628 wants to merge 5 commits into
masterfrom
feat-ac-autocomplete-input
Open

feat(Combobox, Input): added autocomplete prop [run-chromatic]#710
amandac628 wants to merge 5 commits into
masterfrom
feat-ac-autocomplete-input

Conversation

@amandac628

@amandac628 amandac628 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

📖 Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue):

  1. When using input/combobox, browser autofill can cause the dropdown to be blocked:
image

Solution:
- this can be removed by added the autocomplete prop to off as documented
- However, for name='email' it doesn't work
- (known issue, tried using autocomplete='new-password' but still cannot)

✏️ Type of change

Please delete options that are not relevant.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧪 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

✅ Checklist:

  • My code follows the SGDS style guidelines and naming conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@amandac628 amandac628 requested review from clukhei and th-94 June 18, 2026 07:21

if (this._mixinShouldSkipSgdsValidation()) return;

this._mixinValidate(this.input);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related to autocomplete prop?

can explain why need to add this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this because there was this error during input test:

      An error was thrown in a Promise outside a test. Did you forget to await a function or assertion?

But, let me remove it, i just realised that need to test further as it will affect all form related components.

@clukhei clukhei left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the skills for autocomplete prop for the input and combo-box. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants