feat(Combobox, Input): added autocomplete prop [run-chromatic]#710
Open
amandac628 wants to merge 5 commits into
Open
feat(Combobox, Input): added autocomplete prop [run-chromatic]#710amandac628 wants to merge 5 commits into
amandac628 wants to merge 5 commits into
Conversation
clukhei
reviewed
Jun 22, 2026
|
|
||
| if (this._mixinShouldSkipSgdsValidation()) return; | ||
|
|
||
| this._mixinValidate(this.input); |
Collaborator
There was a problem hiding this comment.
is this related to autocomplete prop?
can explain why need to add this?
Collaborator
Author
There was a problem hiding this comment.
added this because there was this error during input test:
An error was thrown in a Promise outside a test. Did you forget to await a function or assertion?
But, let me remove it, i just realised that need to test further as it will affect all form related components.
clukhei
reviewed
Jun 22, 2026
clukhei
left a comment
Collaborator
There was a problem hiding this comment.
Update the skills for autocomplete prop for the input and combo-box. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue):
Solution:
- this can be removed by added the autocomplete prop to off as documented
- However, for
name='email'it doesn't work- (known issue, tried using autocomplete='new-password' but still cannot)
✏️ Type of change
🧪 How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
✅ Checklist: