Skip to content

[Tab] Add support for tone#698

Open
infernova wants to merge 3 commits into
GovTechSG:masterfrom
infernova:feat/tab-tone
Open

[Tab] Add support for tone#698
infernova wants to merge 3 commits into
GovTechSG:masterfrom
infernova:feat/tab-tone

Conversation

@infernova

@infernova infernova commented Jun 8, 2026

Copy link
Copy Markdown

📖 Description

  • Adds to sgds-tab the following tone variants: neutral, inverse, fixed-light, and fixed-dark.
  • Expanded color library with the following colors: --sgds-bg-translucent-inverse-emphasis, --sgds-bg-translucent-fixed-light-emphasis, and --sgds-bg-translucent-fixed-dark-emphasis. All -emphasis variants are 50% opacity variants of exisiting --sgds-bg-translucent-* colors.
  • Updated sgds-spinner stories to be easier to read.

Implements #697

✏️ Type of change

  • New feature (non-breaking change which adds functionality)

🧪 How Has This Been Tested?

  • Updated existing unit test to include tone updates

✅ Checklist:

  • My code follows the SGDS style guidelines and naming conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Jesmond Chia added 2 commits June 9, 2026 17:58
Added `--sgds-bg-translucent-inverse-emphasis`, `--sgds-bg-translucent-fixed-dark-emphasis`, and
`--sgds-bg-translucent-fixed-light-emphasis` colors
Added `brand`, `neutral`, `inverse`, `fixed-light`, and `fixed-dark` tone variants
@clukhei

clukhei commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Pending design from @anzteng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants