fix(#3505): Fix icon click and focus on Link#3664
Merged
chrisolsen merged 1 commit intodevfrom Mar 25, 2026
Merged
Conversation
bdfranck
force-pushed
the
copilot/3505-fix-link-icon-click
branch
from
9ace3eb to
e7a3430
Compare
chrisolsen
reviewed
Mar 24, 2026
| const spy = vi.fn(); | ||
|
|
||
| result.container | ||
| .querySelector("[data-testid='anchor']") |
Collaborator
There was a problem hiding this comment.
You could replace this with
cont anchor = result.getByTestId("anchore");
...
await waitFor(() => {
anchor.element().addEventListener(...)
})
|
|
||
| result.container | ||
| .querySelector("[data-testid='anchor']") | ||
| ?.addEventListener("click", spy); |
Collaborator
Author
There was a problem hiding this comment.
Good point! I've updated the tests.
bdfranck
force-pushed
the
copilot/3505-fix-link-icon-click
branch
from
e7a3430 to
2fa68e8
Compare
ArakTaiRoth
approved these changes
Mar 25, 2026
chrisolsen
approved these changes
Mar 25, 2026
Collaborator
|
🎉 This PR is included in version 1.41.0-dev.27 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 6.11.0-dev.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues in the link component: