feat(#3080): New Foundation pages by ArakTaiRoth · Pull Request #3611 · GovAlta/ui-components

ArakTaiRoth · 2026-03-19T21:35:01Z

Before (the change)

After (the change)

This adds the Foundation pages requested in #3080 . The content for these pages is found here and in the pages linked to below this page.

All pages are located at /foundations

Refer to the story for what pages are done and reviewable, those are checked off

netlify · 2026-03-20T20:30:03Z

✅ Deploy Preview for goa-design-2 ready!

Name	Link
🔨 Latest commit	`90f8567`
🔍 Latest deploy log	https://app.netlify.com/projects/goa-design-2/deploys/69bdae49390b2f000829f4b6
😎 Deploy Preview	https://deploy-preview-3611--goa-design-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Spark450

This review includes the following so far:

Overview
Accessibility
Brand guidelines
- Style guide -> Colour
- Style guide -> Iconography

Spark450

A few more comments, still working through the remainder of the pages.

Spark450

Okay these are the last of them 😅

ArakTaiRoth · 2026-03-24T05:13:29Z

@Spark450 All the changes you requested have been made

Spark450

Just a few comments on Layout, Illustration looks good!

Spark450 · 2026-03-26T23:20:36Z

The changes look good @ArakTaiRoth approved. Lets get this out of draft so we can release what we have.

Copilot

Pull request overview

Adds the requested /foundations documentation section to the Astro docs site, including new style-guide and content-guideline pages and updates to navigation so Foundations appears in the site menu hierarchy.

Changes:

Added multiple new Foundations pages (Design at GoA, Accessibility, Brand guidelines, Style guide pages, Content guidelines pages).
Updated docs navigation to include Foundations as a top-level section with a dedicated submenu and grouped pages.
Added shared UI helpers for Foundations pages (support callout, static grid wrapper) and adjusted DoDont behavior for static guidance content.

Reviewed changes

Copilot reviewed 20 out of 37 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
docs/src/pages/foundations/index.astro	Updates Foundations landing page content and adds support callout.
docs/src/pages/foundations/accessibility.astro	Adds Accessibility foundations page.
docs/src/pages/foundations/brand-guidelines.astro	Adds Brand guidelines foundations page.
docs/src/pages/foundations/style-guide/colour.astro	Adds Colour style guide page with token lists.
docs/src/pages/foundations/style-guide/iconography.astro	Adds Iconography style guide page and icon-size table.
docs/src/pages/foundations/style-guide/illustration.astro	Adds Illustration style guide page with token lists and process guidance.
docs/src/pages/foundations/style-guide/layout.astro	Adds Layout style guide page.
docs/src/pages/foundations/style-guide/logo.astro	Adds Logo style guide page and related images.
docs/src/pages/foundations/style-guide/photography.astro	Adds Photography style guide page.
docs/src/pages/foundations/style-guide/typography.astro	Adds Typography style guide page.
docs/src/pages/foundations/content-guidelines/capitalization.astro	Adds Capitalization content guideline page.
docs/src/pages/foundations/content-guidelines/helper-text.astro	Adds Helper text content guideline page with Do/Dont previews.
docs/src/components/nav/ParentMenu.tsx	Adds Foundations to top-level nav sections and tightens types.
docs/src/components/nav/FoundationsSubMenu.tsx	Adds Foundations submenu pages/groups and navigation handling.
docs/src/components/SiteNav.tsx	Updates documentation/comments for submenu behavior including Foundations.
docs/src/components/FoundationsSupportCallout.astro	Adds reusable “Need help…” callout used across Foundations pages.
docs/src/components/StaticGuidanceGrid.astro	Adds shared responsive grid wrapper for static Do/Dont layouts.
docs/src/components/DoDont.astro	Adjusts wrapper logic for static pages and adds preview sizing handling.
docs/public/images/foundations/**	Adds new images used by Foundations pages.

bdfranck

I reviewed the of the completed pages...

I fixed a couple minor grammar issues
I fixed some issues flagged by Copilot
I removed all duplicate icons in the "Extended icon set" section

The result looks good to me! 👍

Spark450

Just a few small ones to address, looks good @bdfranck

Spark450

Thanks for taking care of those comments @bdfranck

Can you do a quick review @chrisolsen

twjeffery

A few issues:

Foundations should be at the bottom of the nav items (last, under Tokens).

Foundations should have a secondary side nav like the rest of the main sections (like Components and Get started) so that there is not multiple levels of nesting.

(BUG) Right now when you click a page in foundations it goes to that page but changes the secondary side menu for foundations (that I reference above).
These need to be consolidated, and all foundations pages should use this secondary menu.

Screen.Recording.2026-03-30.at.6.04.33.PM.mov

Remove the icon on the style guide and content guidelines groups.

ArakTaiRoth · 2026-03-31T00:22:37Z

A few issues:

Foundations should be at the bottom of the nav items (last, under Tokens).

2. Foundations should have a secondary side nav like the rest of the main sections (like Components and Get started) so that there is not multiple levels of nesting.

(BUG) Right now when you click a page in foundations it goes to that page but changes the secondary side menu for foundations (that I reference above).

These need to be consolidated, and all foundations pages should use this secondary menu.

Screen.Recording.2026-03-30.at.6.04.33.PM.mov

3. Remove the icon on the style guide and content guidelines groups.

@twjeffery Regarding your issue #2 and #3. Those changes are already in place if you pull this down, build it, and run it locally you'll see. For some reason the netlify deploy never got updated after the initial creation of this PR.

twjeffery · 2026-03-31T00:25:43Z

A few issues:

Foundations should be at the bottom of the nav items (last, under Tokens).

2. Foundations should have a secondary side nav like the rest of the main sections (like Components and Get started) so that there is not multiple levels of nesting.

(BUG) Right now when you click a page in foundations it goes to that page but changes the secondary side menu for foundations (that I reference above).

These need to be consolidated, and all foundations pages should use this secondary menu.

Screen.Recording.2026-03-30.at.6.04.33.PM.mov

3. Remove the icon on the style guide and content guidelines groups.

@twjeffery Regarding your issue #2 and #3. Those changes are already in place if you pull this down, build it, and run it locally you'll see. For some reason the netlify deploy never got updated after the initial creation of this PR.

Ah ok, awesome, good to know. Thanks

chrisolsen · 2026-03-31T18:45:47Z

🎉 This PR is included in version 2.0.0-dev.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:07:21Z

🎉 This PR is included in version 2.0.0-dev.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:08:44Z

🎉 This PR is included in version 7.0.0-dev.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:09:43Z

🎉 This PR is included in version 5.0.0-dev.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:20:41Z

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:29:05Z

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:37:30Z

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:46:09Z

🎉 This PR is included in version 5.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:57:13Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:30:26Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:37:58Z

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:46:21Z

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ArakTaiRoth force-pushed the dustin/3080 branch 2 times, most recently from fb8ec53 to 28729e1 Compare March 19, 2026 23:39

ArakTaiRoth linked an issue Mar 20, 2026 that may be closed by this pull request

Build the “Foundations” section (all pages) #3080

Closed

19 tasks

ArakTaiRoth requested review from Spark450 and twjeffery March 20, 2026 15:47

ArakTaiRoth force-pushed the dustin/3080 branch from 28729e1 to 90f8567 Compare March 20, 2026 20:29

Spark450 reviewed Mar 20, 2026

View reviewed changes

Spark450 reviewed Mar 23, 2026

View reviewed changes

ArakTaiRoth force-pushed the dustin/3080 branch from 90f8567 to b106bf8 Compare March 24, 2026 05:06

ArakTaiRoth force-pushed the dustin/3080 branch from b106bf8 to 34f4da0 Compare March 25, 2026 23:18

Spark450 reviewed Mar 26, 2026

View reviewed changes

Comment thread docs/src/pages/foundations/style-guide/layout.astro

Comment thread docs/src/pages/foundations/style-guide/layout.astro Outdated

Comment thread docs/src/pages/foundations/style-guide/layout.astro Outdated

ArakTaiRoth force-pushed the dustin/3080 branch from 34f4da0 to 8df4423 Compare March 26, 2026 20:55

Spark450 added the P2 Priority 2 (should have): Improves completeness and reduces the post-launch support load. label Mar 26, 2026

bdfranck self-assigned this Mar 27, 2026

bdfranck marked this pull request as ready for review March 27, 2026 21:53

Spark450 self-requested a review March 27, 2026 22:01

bdfranck requested a review from Copilot March 27, 2026 22:16

Copilot started reviewing on behalf of bdfranck March 27, 2026 22:17 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

bdfranck force-pushed the dustin/3080 branch 2 times, most recently from 3cf9a61 to 068cd43 Compare March 27, 2026 23:15

bdfranck approved these changes Mar 27, 2026

View reviewed changes

Spark450 requested changes Mar 30, 2026

View reviewed changes

Spark450 requested a review from bdfranck March 30, 2026 20:14

feat(#3080): New Foundation pages

70d8d52

bdfranck force-pushed the dustin/3080 branch from 068cd43 to 70d8d52 Compare March 30, 2026 23:06

bdfranck requested a review from Spark450 March 30, 2026 23:07

Spark450 approved these changes Mar 30, 2026

View reviewed changes

twjeffery reviewed Mar 31, 2026

View reviewed changes

chrisolsen merged commit d14e272 into dev Mar 31, 2026
4 of 5 checks passed

chrisolsen deleted the dustin/3080 branch March 31, 2026 01:32

chrisolsen added the released on @dev label Mar 31, 2026

chrisolsen added the released on @next label Mar 31, 2026

chrisolsen added the released Released into production. label Mar 31, 2026

Conversation

ArakTaiRoth commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before (the change)

After (the change)

Uh oh!

netlify bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for goa-design-2 ready!

Uh oh!

Spark450 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Spark450 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Spark450 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArakTaiRoth commented Mar 24, 2026

Uh oh!

Spark450 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Spark450 commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdfranck left a comment

Choose a reason for hiding this comment

Uh oh!

Spark450 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArakTaiRoth commented Mar 19, 2026 •

edited

Loading

netlify bot commented Mar 20, 2026 •

edited

Loading