Conversation
chrisolsen
force-pushed
the
chris/docs-deployment
branch
from
f5e461e to
3b1249e
Compare
vanessatran-ddi
left a comment
vanessatran-ddi
left a comment
There was a problem hiding this comment.
I have some comments
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| run: npx nx affected --target release --parallel=false --base=${{ steps.last_successful_commit.outputs.base }} | ||
|
|
||
| - name: Install oc CLI |
There was a problem hiding this comment.
Should we add if: github.ref === 'refs/heads/docs like line 83?
| - name: Update Web components documentation | ||
| run: cp libs/web-components/README.md dist/libs/web-components | ||
|
|
||
| - name: Release libs |
There was a problem hiding this comment.
Question: So we will run this step even branch is docs?
Should we add a condition if: github.ref != 'refs/heads/docs?
There was a problem hiding this comment.
The line is intended
| uses: redhat-actions/oc-login@v1 | ||
| with: | ||
| # URL to your OpenShift cluster. | ||
| # Refer to Step 2. |
There was a problem hiding this comment.
Which step 2 we refer in this comment?
| index index.html; | ||
|
|
||
|
|
||
| location ~* \.(js|css|png|jpg|jpeg|gif|ico)$ { |
There was a problem hiding this comment.
Should we add svg, woff, woff2, ttf too
| events { | ||
| worker_connections 1024; | ||
| } | ||
| http{ |
There was a problem hiding this comment.
Maybe add a small space between http and {
Spark450
added
the
P1
| @@ -0,0 +1,5 @@ | |||
| FROM registry.access.redhat.com/ubi9/nginx-124 | |||
|
|
|||
| COPY . /usr/share/nginx/html | |||
There was a problem hiding this comment.
I think this is wrong. Currently in the nginx.conf, you're pointing to /opt/app-root/src, while here you're copying everything into /usr/share/nginx/html. So this should probably be changed to the same folder used in the nginx.conf. Also would be a good idea to make that directory the WORKDIR.
Also with this, the nginx.conf is being copied here as well, not into the the actual configuration directory, so I don't think it'll be loaded and run properly. I'm not sure what the configuration directory is though on our server, /usr/local/nginx/conf, /etc/nginx, or /usr/local/etc/nginx
4 participants
No description provided.