feat: make icon optional in WorkSideMenuGroup and WorkSideMenuItem#3595
Open
feat: make icon optional in WorkSideMenuGroup and WorkSideMenuItem#3595
Conversation
Copilot
AI
changed the title
[WIP] Add optional icon to WorkSideMenuGroup
feat: make icon optional in WorkSideMenuGroup and WorkSideMenuItem
Mar 16, 2026
29096fe to
d0d5758
Compare
Collaborator
|
Here was my process:
|
chrisolsen
reviewed
Mar 18, 2026
libs/web-components/src/components/work-side-menu/WorkSideMenuItem.svelte
Outdated
Show resolved
Hide resolved
d0d5758 to
e14d613
Compare
chrisolsen
approved these changes
Mar 19, 2026
e14d613 to
329c9e5
Compare
Collaborator
|
I've rebased this commit against the latest |
Added a third test panel showing a back arrow icon on the first item with iconless items and groups below, matching the docs site pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkSideMenuGroupalways rendered a leading icon, reserving space for it even when none was needed — requiring shadow DOM workarounds to hide it.WorkSideMenuItemhad the same issue: thegoa-iconelement was always mounted even with an emptyiconprop.Before (the change)
WorkSideMenuGroup.iconwas required; always rendered agoa-iconin the summary headerWorkSideMenuItemalways mounted agoa-iconelement even whenicon="", consuming layout spaceAfter (the change)
WorkSideMenuGroup—iconis now optional across all three frameworks. The leadinggoa-iconis only rendered wheniconis provided; no space is reserved when omitted.WorkSideMenuItem—goa-iconis conditionally rendered via{#if icon}, consistent with the existing optional prop contract.React / Angular:
iconprop changed from required to optional in both wrappers (GoabWorkSideMenuGroupProps,@Input() icon?: GoabIconType).Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
WorkSideMenuGroupwithout theiconprop — confirm no icon element is mounted and heading text is flush left with no reserved icon gap.WorkSideMenuGroupwithicon="star"— confirm existing icon behavior is unchanged.WorkSideMenuItemwithouticon— confirm no icon element is mounted.WorkSideMenuItemwithicon="star"— confirm icon renders as before.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.