feat(#3579): add push drawer experimental wrappers#3577
Merged
chrisolsen merged 1 commit intodevfrom Mar 18, 2026
Merged
Conversation
✅ Deploy Preview for goa-design-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
twjeffery
changed the title
twjeffery
force-pushed
the
tom/push-drawer-wrappers
branch
2 times, most recently
from
61d1535 to
4a603de
Compare
ArakTaiRoth
reviewed
Mar 16, 2026
libs/angular-components/src/experimental/push-drawer/push-drawer.ts
Outdated
Show resolved
Hide resolved
twjeffery
force-pushed
the
tom/push-drawer-wrappers
branch
from
4a603de to
a452848
Compare
ArakTaiRoth
reviewed
Mar 17, 2026
libs/web-components/src/components/push-drawer/PushDrawerInternal.svelte
Outdated
Show resolved
Hide resolved
libs/web-components/src/components/push-drawer/PushDrawerInternal.svelte
Show resolved
Hide resolved
twjeffery
force-pushed
the
tom/push-drawer-wrappers
branch
2 times, most recently
from
6498749 to
045dee9
Compare
Add GoabxPushDrawer experimental wrappers for React and Angular with version="2" default. Add version prop to PushDrawer and PushDrawerInternal Svelte components. Add version to standard React wrapper WCProps to avoid TS IntrinsicElements conflict. React: 4 tests, Angular: 1 test.
twjeffery
force-pushed
the
tom/push-drawer-wrappers
branch
from
045dee9 to
8681365
Compare
ArakTaiRoth
approved these changes
Mar 18, 2026
chrisolsen
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3579
Test plan
npm run buildpassesnpm run test:prpasses (1 pre-existing failure in TwoColumnLayout unrelated)