Closed
Conversation
❌ Deploy Preview for goa-design-2 failed.
|
bdfranck
force-pushed
the
benji/3511cross-version-nav
branch
2 times, most recently
from
a84b584 to
e03826d
Compare
Collaborator
Author
|
My initial idea was to not link back to the v1 docs. But we discussed how this could be frustrating for teams who have links to design system components in their Jira tickets. A v1 link lets them find the old docs when they haven't been able to upgrade to v2 yet. |
Collaborator
|
@bdfranck are we able to get a deploy preview running for this? |
bdfranck
force-pushed
the
benji/3511cross-version-nav
branch
from
e03826d to
311e45d
Compare
bdfranck
force-pushed
the
benji/3511cross-version-nav
branch
from
82a8eb3 to
3b39b6a
Compare
Collaborator
Author
|
I'm closing this PR b/c the deploy preview isn't working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares our DS 2 docs for links from DS 1 docs with the following changes...
/components/circular-progress-indicator➡️/components/circular-progress)Paths with version segments (ex:(I removed this b/c it caused a deploy issue)/components/v6.0.0+-react/button)The related DS 1 docs changes: GovAlta/ui-components-docs#484