Closed
Conversation
fix(#2397): popover close
- https://github.com/GovAlta/ui-components-design/issues/71 - added list view of components in separate tab - updated images and image styling - reordered component side menu to sort under component categories - added badges to both views of components based on status
- updated token snippet design - added space on top for consistency on content side menu - broke the colour design tokens into separate tables for a better responsive design of the tables - added all new tokens to token documentation - changed name in main nav from Styles to Tokens - updated naming throughout documentation - changed styling of Get support in main nav - other small content changes
- update to all component documentation pages to split content into tabs - moved properties out of accordion into table - wrapped component properties in accordion, set to open on load - updated componentHeader to include link to Github, Figma, and styling update - moved code examples to their own tab - added links to design documentation in Figma on design tab - added links to accessibility documentation in Figma on accessibility tab
- added link to Figma and copy heading link to clipboard to all relevant examples - fixed external link icon size - updated some component examples to align with design
fix(#2577): Change all references to Simple Form to Public Form
feat(#2505): inform user on lts support length
…ilters-examples feat(#1979) table with global filters examples
feat (#71): component status view and documentation updates
fix(#2470): Updated Contribution documentation
fix(#2512): rename "as" attribute as "tag" for text
feat(#2500): Added Stackblitz links to Bug Report form
feat(#2278): add modal drawer doc
fix(#2433): make copy link & toc items to handle tab position
feat(#2594): document link component
fix: update all abgov libs to the latest
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
twjeffery
reviewed
May 1, 2025
Collaborator
twjeffery
left a comment
twjeffery
left a comment
There was a problem hiding this comment.
@chrisolsen I found a few small issues in the docs across all of the changes. The first (wrong links to Figma) I will work on right away. The rest I think we can record and fix soon, they are all pretty small, and not critical.
Wrong Figma links on example
- I moved all of the examples in Figma to a new library. They currently just go to our component library in Figma, should go to each individual example. I will create a fix for this ASAP
Bug
- similar to a previous bug fixed: fix: text styling for hover on current page in app header menu but now with the
<a href="#" className="interactive">on the menu item.
Bug
- typing anything into the component search brings up the drawer (and sometimes multiple drawers….)
Bug
- Link component is not showing active tab on load
Enhancement needed
- notification banner is way too noisy, it keeps coming back on any change. Can we have it remember cookies more, so that if you dismiss it it doesn’t come back on ecvery refresh? What are our options there?
Enhancement needed
- have no text wrap on the link “view the upgrade guide”
- (fixed) typing anything into the component search brings up the drawer (and sometimes multiple drawers….) - (fixed) links to Figma examples need to be updated after Figma library update - (fixed) stop text from wrapping on “view the upgrade guide” link - (fixed) link not showing active tab on load - small updates to component example names and formatting - update to component header to prevent wrapping on github issue count - updated breakpoint for side menu and page content to stack before breaking - updated label on version control to capital "LTS", fixed layout and wrapping issues with version control - adjusted header menu for breakpoint based on current nav items - updated team info
fix: small issues for website release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.