Skip to content

feat(#3529): move letter spacing into seperate tokens#137

Merged
bdfranck merged 1 commit intomainfrom
copilot/move-letter-spacing-value
Mar 23, 2026
Merged

feat(#3529): move letter spacing into seperate tokens#137
bdfranck merged 1 commit intomainfrom
copilot/move-letter-spacing-value

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 18, 2026

This PR moves letter spacing values out of our heading tokens and into their separate values. It assumes the values were px and changes them to rem. These new tokens are implemented in GovAlta/ui-components#3606.

The tokens are the following:

--goa-letter-spacing-2xl:  -0.09375rem;   /* was -1.5  */
--goa-letter-spacing-xl:   -0.09375rem;   /* was -1.5  */
--goa-letter-spacing-l:    -0.078125rem;  /* was -1.25 */
--goa-letter-spacing-m:    -0.0625rem;    /* was -1    */
--goa-letter-spacing-s:    -0.046875rem;  /* was -0.75 */
--goa-letter-spacing-xs:   -0.046875rem;  /* was -0.75 */
--goa-letter-spacing-2xs:  -0.03125rem;   /* was -0.5  */
Original prompt

Address this issue:
GovAlta/ui-components#3529

Move the letter spacing out of the global typography values into separate values.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] [3529] Move letter spacing out of global typography values Move heading letter-spacing out of composite typography tokens into separate companion tokens Mar 18, 2026
Copilot AI requested a review from bdfranck March 18, 2026 17:33
Copilot AI changed the title Move heading letter-spacing out of composite typography tokens into separate companion tokens Convert letter-spacing tokens from unitless to rem Mar 18, 2026
@bdfranck bdfranck changed the title Convert letter-spacing tokens from unitless to rem feat(#3529): move letter spacing into seperate tokens Mar 18, 2026
@bdfranck bdfranck force-pushed the copilot/move-letter-spacing-value branch from f8355ba to 578076d Compare March 18, 2026 21:41
@bdfranck bdfranck marked this pull request as ready for review March 19, 2026 15:04
Copy link
Copy Markdown
Collaborator

@willcodeforcoffee willcodeforcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisolsen
Copy link
Copy Markdown
Collaborator

@bdfranck there are conflicts that need to be resolved

@bdfranck bdfranck force-pushed the copilot/move-letter-spacing-value branch from 578076d to 78a6af6 Compare March 23, 2026 20:20
@bdfranck
Copy link
Copy Markdown
Collaborator

I've resolved the merge conflicts and fixed the commit message. 👍

@bdfranck bdfranck merged commit a707948 into main Mar 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heading letter-spacing values missing from compiled CSS

5 participants