Stop looking for key in config when found#495
Open
jonakeys wants to merge 2 commits intoGothenburgBitFactory:developfrom
Open
Stop looking for key in config when found#495jonakeys wants to merge 2 commits intoGothenburgBitFactory:developfrom
jonakeys wants to merge 2 commits intoGothenburgBitFactory:developfrom
Conversation
Signed-off-by: Jonathan van der Steege <jonathan@jonakeys.nl>
Signed-off-by: Jonathan van der Steege <jonathan@jonakeys.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue that multiple keys at the same level in the config are being overwritten. Like it's described in #464.
The tests passed, except for test 6 in help.t (
timew help with unknown argument should show error message) but that also fails in develop.I searched for unwanted side effects of this fix, but as far as I could find there are no duplicate keys in a config file at the same level.
If you wish for a different fix; please say so and I will do rework.
Fixes #464